Skip to content

add Flask-Session to Flask v1.1.4 and Flask v2.0.2#15027

Merged
smoors merged 1 commit intoeasybuilders:developfrom
lexming:20220222154537_new_pr_Flask114
Feb 23, 2022
Merged

add Flask-Session to Flask v1.1.4 and Flask v2.0.2#15027
smoors merged 1 commit intoeasybuilders:developfrom
lexming:20220222154537_new_pr_Flask114

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Feb 22, 2022

(created using eb --new-pr)

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 22, 2022

@boegelbot: please test @ generoso

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 22, 2022

Test report by @lexming
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node305.hydra.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/b22e7f23affb318c2b86b00b196e0b7c for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 22, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=15027 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15027 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8170

Test results coming soon (I hope)...

Details

- notification for comment with ID 1048219464 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 22, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/43b020a43dc4483d48b17206201c6293 for a full test report.

@smoors smoors added this to the next release (4.5.4?) milestone Feb 23, 2022
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Feb 23, 2022

Test report by @smoors
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node200.hydra.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2680 v4 @ 2.40GHz (broadwell), Python 2.7.5
See https://gist.github.com/cb78e2643bd27f2d3ddda5df6dbae9b4 for a full test report.

smoors
smoors approved these changes Feb 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Feb 23, 2022

Going in, thanks @lexming!

@smoors smoors merged commit 902fc94 into easybuilders:develop Feb 23, 2022
@lexming lexming deleted the 20220222154537_new_pr_Flask114 branch February 23, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@lexming @boegelbot @smoors