Skip to content

add patches for mauveAligner to fix build on RHEL8#15049

Merged
smoors merged 2 commits intoeasybuilders:developfrom
boegel:20220225110027_new_pr_mauveAligner4736
Feb 27, 2022
Merged

add patches for mauveAligner to fix build on RHEL8#15049
smoors merged 2 commits intoeasybuilders:developfrom
boegel:20220225110027_new_pr_mauveAligner4736

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 25, 2022

(created using eb --new-pr)

@boegel boegel added the bug fix label Feb 25, 2022
@boegel boegel added this to the next release (4.5.4?) milestone Feb 25, 2022
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 25, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 25, 2022

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15049 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15049 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8184

Test results coming soon (I hope)...

Details

- notification for comment with ID 1050709083 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 25, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3103.skitty.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/d97019712f32cad36b101aade3471e18 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 25, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/56f5d116bc5e91404c0ed300c13744eb for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 25, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3524.doduo.os - Linux RHEL 8.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/cb8c467479521ac3517428be55154e56 for a full test report.

smoors
smoors reviewed Feb 26, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/m/mauveAligner/mauveAligner-4736_fix-getopt.patch
smoors
smoors reviewed Feb 26, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/m/mauveAligner/sgEvolver-4736_fix-getopt.patch
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 26, 2022

@smoors I'l try to use this PR to test an enhancement to the tests to make the test suite fail if the patch description is missing (that may involve a couple of forced pushes in here).

@boegel boegel force-pushed the 20220225110027_new_pr_mauveAligner4736 branch 2 times, most recently from 253f8c5 to a386134 Compare February 26, 2022 16:33
@easybuilders easybuilders deleted a comment from boegelbot Feb 26, 2022
@boegel boegel mentioned this pull request Feb 26, 2022
Merged
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 26, 2022

Check for proper patch description works, I fleshed that out into a separate PR: #15061

@easybuilders easybuilders deleted a comment from boegelbot Feb 27, 2022
@boegel boegel force-pushed the 20220225110027_new_pr_mauveAligner4736 branch from 76e6294 to 52dacd9 Compare February 27, 2022 14:25
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 27, 2022

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
node2626.swalot.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/5f699b6d3bd2c705ad214d0dd673386f for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Feb 27, 2022

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node300.hydra.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/19da039b34f5027a4cde0c8788c9695e for a full test report.

smoors
smoors approved these changes Feb 27, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Feb 27, 2022

Going in, thanks @boegel!

@smoors smoors merged commit 4141f54 into easybuilders:develop Feb 27, 2022
@boegel boegel deleted the 20220225110027_new_pr_mauveAligner4736 branch February 28, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @smoors