Skip to content

add M4 as build dependency for CCL-1.12 #15075

Merged
bedroge merged 1 commit intoeasybuilders:developfrom
JensTimmerman:patch-3
Mar 4, 2022
Merged

add M4 as build dependency for CCL-1.12 #15075
bedroge merged 1 commit intoeasybuilders:developfrom
JensTimmerman:patch-3

Conversation

@JensTimmerman
Copy link
Copy Markdown

@JensTimmerman JensTimmerman commented Mar 3, 2022

without m4 I get /bin/sh: 1: m4: not found and the build fails a bit later with /../pmcl-kernel.c:1555: undefined reference to `spjump_start'

see also https://shammerism.hatenadiary.com/entry/20160114/p1

add m4 as build dependency for CCL
8336928 
without m4 I get` /bin/sh: 1: m4: not found`  and the build fails a bit later with /../pmcl-kernel.c:1555: undefined reference to `spjump_start'
@JensTimmerman
Copy link
Copy Markdown
Author

JensTimmerman commented Mar 3, 2022

@boegel I'm not sure why this doesn't fail in the building tests, m4 might be available on the systems somehow?
it fails for me on centos 8 clean install

@JensTimmerman JensTimmerman changed the title add m4 as build dependency for CCL {lang}[GCCcore/9.3.0]CCL-1.12 add m4 as build dependency Mar 3, 2022
@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Mar 4, 2022 •
edited
Loading

I think a lot of systems indeed already have this package installed on the OS level, but since the manual also states (https://ccl.clozure.com/docs/ccl.html#kernel-build-prerequisites) that you really need it, it completely makes sense to add it as a build dependency:

In order to build the lisp kernel, you must have installed a C compiler and its associated tools (such as as and ld). Additionally, the lisp kernel build process uses m4; this program is often not installed by default, so make sure you have it. The lisp kernel makefiles generally assume that you are using GNU make.

@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Mar 4, 2022

@boegelbot please test @ generoso

@bedroge bedroge added the bug fix label Mar 4, 2022
@bedroge bedroge added this to the 4.x milestone Mar 4, 2022
@bedroge bedroge changed the title {lang}[GCCcore/9.3.0]CCL-1.12 add m4 as build dependency add M4 as build dependency for CCL-1.12 Mar 4, 2022
@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Mar 4, 2022

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 20.04, x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.8.10
See https://gist.github.com/ea72f02e2c1f3210f8e64fc1a85b5401 for a full test report.

@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Mar 4, 2022

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
pg-interactive.hpc.rug.nl - Linux UNKNOWN UNKNOWN, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 3.6.8
See https://gist.github.com/fee2efa6ad71b447ed4a9ef98a0762c9 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 4, 2022

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=15075 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15075 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8222

Test results coming soon (I hope)...

Details

- notification for comment with ID 1059183740 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 4, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/20a932bdcae882a2c7548922f33f751b for a full test report.

bedroge
bedroge approved these changes Mar 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bedroge bedroge modified the milestones: 4.x, next release (4.5.4?) Mar 4, 2022
@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Mar 4, 2022

Going in, thanks @JensTimmerman!

@bedroge bedroge merged commit 9a4a115 into easybuilders:develop Mar 4, 2022
@bedroge bedroge mentioned this pull request Mar 4, 2022
Merged
@JensTimmerman
Copy link
Copy Markdown
Author

JensTimmerman commented Mar 5, 2022 •
edited
Loading

@bedroge I created https://github.com/boegel/boegelbot/pull/18/files to make sure the tests don't pick up the system m4 from $PATH if it is available in the test env

some packages could still use a hardcoded /usr/bin/m4 of course...

But I thought EB already had some PATH cleaning in the build process to keep this from happening, this might have been removed somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bedroge bedroge bedroge approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@JensTimmerman @bedroge @boegelbot