Skip to content

use x.py to bootstrap Rust so that build options are properly passed through#15211

Merged
SebastianAchilles merged 6 commits intoeasybuilders:developfrom
jfgrimm:20220330171541_new_pr_Rust1540
Apr 12, 2022
Merged

use x.py to bootstrap Rust so that build options are properly passed through#15211
SebastianAchilles merged 6 commits intoeasybuilders:developfrom
jfgrimm:20220330171541_new_pr_Rust1540

Conversation

@jfgrimm
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm commented Mar 30, 2022

@jfgrimm jfgrimm added this to the 4.x milestone Mar 30, 2022
boegel
boegel previously requested changes Mar 30, 2022
Comment thread easybuild/easyconfigs/r/Rust/Rust-1.54.0-GCCcore-11.2.0.eb
@boegel boegel added the bug fix label Mar 30, 2022
@boegel boegel modified the milestones: 4.x, release after 4.5.4 Mar 30, 2022
@SebastianAchilles
Copy link
Copy Markdown
Member

@boegelbot please test @ jsc-zen2
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15211 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15211 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1104

Test results coming soon (I hope)...

Details

- notification for comment with ID 1084731085 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2g1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/4c0bc4640fc1719114362a8a78358f35 for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=15211 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15211 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8353

Test results coming soon (I hope)...

Details

- notification for comment with ID 1085087455 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/4a92e1168e29c074a22a438c06d1a161 for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

@boegelbot please test @ jsc-zen2
CORE_CNT=16
EB_ARGS="--buildpath=/dev/shm/$USER"

@boegelbot
Copy link
Copy Markdown
Collaborator

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15211 EB_ARGS="--buildpath=/dev/shm/$USER" /opt/software/slurm/bin/sbatch --job-name test_PR_15211 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1112

Test results coming soon (I hope)...

Details

- notification for comment with ID 1085783870 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 7 out of 12 (8 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/724c33b91710683b103b5bdc415b2824 for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

@jfgrimm The older Rust versions failed in because python is not installed in the OS (only python3 is installed). I think they would also fail on generoso because also there python is not installed.
One idea could be to add Python/2.x as build dependency. What do you think about that?

@jfgrimm
Copy link
Copy Markdown
Member Author

jfgrimm commented Apr 1, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
node131.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/379a0c6e57d6f35a906bcc53c1a686b3 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member Author

jfgrimm commented Apr 7, 2022

@SebastianAchilles requires #15259 now for the relevant Python*-bare easyconfigs

@SebastianAchilles
Copy link
Copy Markdown
Member

@boegelbot please test @ jsc-zen2
CORE_CNT=16
EB_ARGS="--buildpath=/dev/shm/$USER"

@boegelbot
Copy link
Copy Markdown
Collaborator

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15211 EB_ARGS="--buildpath=/dev/shm/$USER" /opt/software/slurm/bin/sbatch --job-name test_PR_15211 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1115

Test results coming soon (I hope)...

Details

- notification for comment with ID 1094601783 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 28 out of 28 (9 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/6a9181f2515ffc64b0dc0a5d2ca2e3c1 for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=15211 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15211 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8365

Test results coming soon (I hope)...

Details

- notification for comment with ID 1095017184 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 9 out of 9 (9 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/8bbf8f02c36c9b1f2fa7c23ad0d7a1aa for a full test report.

@SebastianAchilles SebastianAchilles dismissed boegel’s stale review April 12, 2022 18:20

Additional comments are added.

Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

Going in, thanks @jfgrimm!

@SebastianAchilles SebastianAchilles merged commit 743ab64 into easybuilders:develop Apr 12, 2022
@SebastianAchilles SebastianAchilles changed the title use x.py to boostrap Rust so that build options are properly passed through use x.py to bootstrap Rust so that build options are properly passed through Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants