Skip to content

remove pkg-config use from SeqLib configure patch (avoids problem due to faulty autoconf macro)#15316

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
ComputeCanada:seqlib-fix-patch
Apr 23, 2022
Merged

remove pkg-config use from SeqLib configure patch (avoids problem due to faulty autoconf macro)#15316
jfgrimm merged 1 commit intoeasybuilders:developfrom
ComputeCanada:seqlib-fix-patch

Conversation

@bartoldeman
Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman commented Apr 21, 2022

There was a syntax error in the autoconf macro, which causes an
error if pkg-config is available, and if not available simply
causes configure to issue a warning and ignore it.

Since the result is not used anyway, we can remove it.

@bartoldeman
Remove pkg-config use from SeqLib configure patch
5f4a3cb 
There was a syntax error in the autoconf macro, which causes an
error if pkg-config is available, and if not available simply
causes configure to issue a warning and ignore it.

Since the result is not used anyway, we can remove it.
@bartoldeman bartoldeman requested a review from jfgrimm April 21, 2022 11:16
@bartoldeman bartoldeman added this to the next release (4.5.5?) milestone Apr 21, 2022
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Apr 21, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 21, 2022

@jfgrimm: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15316 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15316 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1139

Test results coming soon (I hope)...

Details

- notification for comment with ID 1105078062 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 21, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 12 out of 12 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/0d5bf2db7c25dee27a2a47f67f4e09a7 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Apr 23, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 23, 2022

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=15316 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15316 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8409

Test results coming soon (I hope)...

Details

- notification for comment with ID 1107442011 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 23, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/e7c53928037072921871f12bcb1da058 for a full test report.

jfgrimm
jfgrimm approved these changes Apr 23, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfgrimm jfgrimm merged commit f4f2e8e into easybuilders:develop Apr 23, 2022
@boegel boegel changed the title Remove pkg-config use from SeqLib configure patch remove pkg-config use from SeqLib configure patch (avoids problem due to faulty autoconf macro) Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

3 participants

@bartoldeman @jfgrimm @boegelbot