Skip to content

define $HHLIB as path to HH-suite installation directory, required by Perl scripts#15324

Merged
boegel merged 1 commit intoeasybuilders:developfrom
akesandgren:20220422134242_new_pr_HH-suite330
Apr 22, 2022
Merged

define $HHLIB as path to HH-suite installation directory, required by Perl scripts#15324
boegel merged 1 commit intoeasybuilders:developfrom
akesandgren:20220422134242_new_pr_HH-suite330

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Apr 22, 2022

(created using eb --new-pr)

@akesandgren akesandgren added this to the 4.x milestone Apr 22, 2022
@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Apr 22, 2022

@boegelbot Please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 22, 2022

@akesandgren: Request for testing this PR well received on login1

PR test command 'EB_PR=15324 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15324 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8403

Test results coming soon (I hope)...

Details

- notification for comment with ID 1106445915 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 22, 2022

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 3 (3 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/28bdc8dc3230b095c52fa21ceebeb7c6 for a full test report.

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Apr 22, 2022

Test report by @akesandgren
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
b-an02.hpc2n.umu.se - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 3.8.10
See https://gist.github.com/7082db421f2babb80ed4aaa9ca07004e for a full test report.

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Apr 22, 2022

@boegelbot Please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 22, 2022

@akesandgren: Request for testing this PR well received on login1

PR test command 'EB_PR=15324 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15324 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8405

Test results coming soon (I hope)...

Details

- notification for comment with ID 1106513506 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 22, 2022 •
edited by boegel
Loading

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/46994854fef0bd60646703c2db189439 for a full test report.

edit (by @boegel): test was failing because the testing done for #15320 had unwanted side-effect of removing all GCCcore modules... 🤦

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 22, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 22, 2022

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15324 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15324 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8406

Test results coming soon (I hope)...

Details

- notification for comment with ID 1106627589 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 22, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/87296f31e87cf1baa3dc8ebc6c10ba0a for a full test report.

@boegel boegel changed the title perl scripts in HH-suite need HHLIB set to the installation dir. define $HHLIB as path to HH-suite installation directory, required by Perl scripts Apr 22, 2022
boegel
boegel approved these changes Apr 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel modified the milestones: 4.x, next release (4.5.5?) Apr 22, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 22, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node2619.swalot.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/3de9efde1f246bcb253219e07ac3bf63 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 22, 2022

Going in, thanks @akesandgren!

@boegel boegel merged commit 16096e9 into easybuilders:develop Apr 22, 2022
@akesandgren akesandgren deleted the 20220422134242_new_pr_HH-suite330 branch April 22, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

3 participants

@akesandgren @boegelbot @boegel