Skip to content

add missing dependencies for libheif (libpng, libjpeg-turbo) + switch to configuring build with CMake so libde265 dependency is picked up#15408

Merged
verdurin merged 2 commits intoeasybuilders:developfrom
boegel:20220503100009_new_pr_libheif1120
May 11, 2022
Merged

add missing dependencies for libheif (libpng, libjpeg-turbo) + switch to configuring build with CMake so libde265 dependency is picked up#15408
verdurin merged 2 commits intoeasybuilders:developfrom
boegel:20220503100009_new_pr_libheif1120

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 3, 2022

(created using eb --new-pr)

@boegel
add missing dependencies for libheif (libpng, libjpeg-turbo) + switch…
1210e13 
… to configuring build with CMake to libde265 dependency is picked up
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented May 3, 2022

Test report by @jfgrimm
FAILED
Build succeeded for 3 out of 4 (1 easyconfigs in total)
node134.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/1498c6cf94628bdd9d67d9a7d2496239 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented May 3, 2022 

9409 CMake Error at gdk-pixbuf/cmake_install.cmake:60 (file):                                                                
9410   file INSTALL cannot copy file                                                                                         
9411   "/tmp/jfg508/libheif/1.12.0/GCC-11.2.0/easybuild_obj/gdk-pixbuf/libpixbufloader-heif.so"                              
9412   to "/usr/lib64/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-heif.so":                                                
9413   Permission denied.                                                                                                    
9414 Call Stack (most recent call first):                                                                                    
9415   cmake_install.cmake:53 (include)

@jfgrimm jfgrimm added the bug fix label May 3, 2022
@jfgrimm jfgrimm added this to the next release (4.5.5?) milestone May 3, 2022
@jfgrimm jfgrimm changed the title add missing dependencies for libheif (libpng, libjpeg-turbo) + switch to configuring build with CMake to libde265 dependency is picked up add missing dependencies for libheif (libpng, libjpeg-turbo) + switch to configuring build with CMake so libde265 dependency is picked up May 3, 2022
jfgrimm
jfgrimm requested changes May 3, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/l/libheif/libheif-1.12.0-GCC-11.2.0.eb
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 10, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 10, 2022

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15408 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15408 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8528

Test results coming soon (I hope)...

Details

- notification for comment with ID 1122676178 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 10, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2619.swalot.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/ce1e8117e1a2a5ef5f6a0656b7ece5bf for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 10, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/4bb3540e97387f6a6180118e3f71cffe for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 10, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3100.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/e50b604c4302c2086e8b8c48b3e7bd19 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented May 11, 2022

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/c32c58a0521a6fd84db898e0e5da0690 for a full test report.

verdurin
verdurin approved these changes May 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented May 11, 2022

@jfgrimm could you confirm you're happy with the fix?

@verdurin
Copy link
Copy Markdown
Member

verdurin commented May 11, 2022

Going in, thanks @boegel!

@verdurin verdurin merged commit de86a6a into easybuilders:develop May 11, 2022
@boegel boegel deleted the 20220503100009_new_pr_libheif1120 branch May 29, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @jfgrimm @boegelbot @verdurin