Skip to content

Add download_instructions to Java 1.8 > 200#15412

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
branfosj:20220503114005_new_pr_Java180_202
May 10, 2022
Merged

Add download_instructions to Java 1.8 > 200#15412
verdurin merged 1 commit intoeasybuilders:developfrom
branfosj:20220503114005_new_pr_Java180_202

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented May 3, 2022

(created using eb --new-pr)

related to #15409

To see the impact of this: eb --fetch --force-download --sourcepath /some/tmp/dir --from-pr 15412 (creating and using a suitable tmp directory for /some/tmp/dir). However, to see the download_instructions requires the source file to be unavailable and that gives a failed build.

@branfosj branfosj added this to the next release (4.5.5?) milestone May 3, 2022
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Copy Markdown
Member

Going in, thanks @branfosj!

@verdurin verdurin merged commit 326974b into easybuilders:develop May 10, 2022
@branfosj branfosj deleted the 20220503114005_new_pr_Java180_202 branch May 10, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants