Skip to content

{lib}[foss/2021a] PyTorch-Ignite v0.4.9 w/ Python 3.9.5#15491

Merged
branfosj merged 3 commits intoeasybuilders:developfrom
smoors:20220512122310_new_pr_PyTorch-Ignite049
Jan 31, 2023
Merged

{lib}[foss/2021a] PyTorch-Ignite v0.4.9 w/ Python 3.9.5#15491
branfosj merged 3 commits intoeasybuilders:developfrom
smoors:20220512122310_new_pr_PyTorch-Ignite049

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented May 12, 2022

(created using eb --new-pr)

@smoors smoors added the new label May 12, 2022
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented May 12, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node134.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/29fb18c71fcbfe875c8d8b4225bff045 for a full test report.

jfgrimm
jfgrimm requested changes May 12, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/p/PyTorch-Ignite/PyTorch-Ignite-0.4.9-foss-2021a-CUDA-11.3.1.eb Outdated
jfgrimm
jfgrimm previously requested changes May 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably worth switching to PythonPackage since it's currently only a single extension?

Comment thread easybuild/easyconfigs/p/PyTorch-Ignite/PyTorch-Ignite-0.4.9-foss-2021a-CUDA-11.3.1.eb
Comment thread easybuild/easyconfigs/p/PyTorch-Ignite/PyTorch-Ignite-0.4.9-foss-2021a-CUDA-11.3.1.eb
@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented May 16, 2022

probably worth switching to PythonPackage since it's currently only a single extension?

actually, I prefer to always use PythonBundle as it's easier to add extensions later on (which is bound to happen at some point).
do you know if there's any advantage of using PythonPackage besides "consistency"?

@smoors smoors mentioned this pull request Jun 8, 2022
Open
jfgrimm
jfgrimm reviewed Oct 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As decided in issue #16330, we have deprecated the use of True to signify a system-toolchain dependency (#16384), in favour of the more intuitive SYSTEM template constant. Due to the change in the test suite, please run eb --sync-pr-with-develop 15491 and update the PR to use SYSTEM instead.

@smoors smoors dismissed jfgrimm’s stale review January 31, 2023 08:40

as decided during an EB conf call, both PythonPackage and PythonBundle are ok.

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Jan 31, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 31, 2023

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=15491 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_15491 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10093

Test results coming soon (I hope)...

Details

- notification for comment with ID 1409967805 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 31, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/710e4f5413a6d7ee5e8b52fcf713ab29 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jan 31, 2023

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0103u14a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6330 CPU @ 2.00GHz (icelake), 1 x NVIDIA NVIDIA A30, 520.61.05, Python 3.6.8
See https://gist.github.com/f5f9813fcb842a1c032865fa2c780a09 for a full test report.

@branfosj branfosj added this to the next release (4.7.1?) milestone Jan 31, 2023
@branfosj branfosj requested review from jfgrimm and removed request for jfgrimm January 31, 2023 18:35
@branfosj branfosj merged commit d6ca52a into easybuilders:develop Jan 31, 2023
@smoors smoors deleted the 20220512122310_new_pr_PyTorch-Ignite049 branch January 21, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm left review comments

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@smoors @jfgrimm @boegelbot @branfosj