Skip to content

allow external tools to be located elsewhere for ETE#15578

Merged
Micket merged 1 commit intoeasybuilders:developfrom
smoors:20220531182135_new_pr_ETE312
Jun 1, 2022
Merged

allow external tools to be located elsewhere for ETE#15578
Micket merged 1 commit intoeasybuilders:developfrom
smoors:20220531182135_new_pr_ETE312

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented May 31, 2022

(created using eb --new-pr)

@smoors smoors added this to the 4.x milestone May 31, 2022
Micket
Micket approved these changes May 31, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jun 1, 2022

got any of those fancy test reports?

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Jun 1, 2022

@boegelbot: please test @ generoso

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Jun 1, 2022

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node381.hydra.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/86f5aeb9eb0e8cbd0901664a1367dc7a for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 1, 2022

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=15578 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15578 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8620

Test results coming soon (I hope)...

Details

- notification for comment with ID 1143876974 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 1, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3794679dfb161cedb9beea930701a6e5 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jun 1, 2022

Going in, thanks @smoors!

@Micket Micket merged commit a566417 into easybuilders:develop Jun 1, 2022
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jun 1, 2022

Test report by @Micket
SUCCESS
Build succeeded for 22 out of 22 (1 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/97a20a828e909e2b3ab962eda505a941 for a full test report.

@boegel boegel modified the milestones: 4.x, 4.5.5 Jun 5, 2022
@smoors smoors deleted the 20220531182135_new_pr_ETE312 branch January 21, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

4 participants

@smoors @Micket @boegelbot @boegel