Skip to content

also build shared library + fix $PYTHONPATH for gmsh 4.9.0#15579

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
Micket:20220531184803_new_pr_gmsh490
May 31, 2022
Merged

also build shared library + fix $PYTHONPATH for gmsh 4.9.0#15579
branfosj merged 1 commit intoeasybuilders:developfrom
Micket:20220531184803_new_pr_gmsh490

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented May 31, 2022

(created using eb --new-pr)

@Micket Micket added the bug fix label May 31, 2022
@Micket Micket added this to the next release (4.5.5?) milestone May 31, 2022
branfosj
branfosj previously approved these changes May 31, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 31, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 31, 2022

@branfosj: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15579 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15579 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1246

Test results coming soon (I hope)...

Details

- notification for comment with ID 1142400405 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 31, 2022

Test report by @branfosj
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/7c5e7bc553318f60c4742b7f0242e85a for a full test report.

@branfosj branfosj dismissed their stale review May 31, 2022 17:25

build failed

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 31, 2022

Ah, my failure was caused by old options in ~/.gmsh-options - see https://gitlab.onelab.info/gmsh/gmsh/-/issues/1048

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 31, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/6a3976ebf07a55a3b1931e384bb1eb87 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 31, 2022

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/78f1e9f0f0e0c68908c0e1dd68f40806 for a full test report.

branfosj
branfosj approved these changes May 31, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 31, 2022

Going in, thanks @Micket!

@branfosj branfosj merged commit 24e73a3 into easybuilders:develop May 31, 2022
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 31, 2022

Test report by @Micket
SUCCESS
Build succeeded for 19 out of 19 (1 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/3d5037977df4dd35b5f91672bd85f8f3 for a full test report.

@boegel boegel changed the title Fix gmsh 4.9.0 lib and python bindings also build shared library + fix $PYTHONPATH for gmsh 4.9.0 Jun 1, 2022
@Micket Micket deleted the 20220531184803_new_pr_gmsh490 branch April 21, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

3 participants

@Micket @branfosj @boegelbot