Skip to content

fix download of thrift 0.12.0 for Arrow 0.16.0#15597

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
boegel:20220603093650_new_pr_Arrow0160
Jun 3, 2022
Merged

fix download of thrift 0.12.0 for Arrow 0.16.0#15597
branfosj merged 1 commit intoeasybuilders:developfrom
boegel:20220603093650_new_pr_Arrow0160

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 3, 2022

(created using eb --new-pr)
installing Arrow 0.16.0 currently fails because the download of thrift 0.12.0 no longer works, unless the archive download URL is used

It would be better to avoid the download all together, but that'll require more effort...

@boegel boegel added the bug fix label Jun 3, 2022
@boegel boegel added this to the next release (4.5.5?) milestone Jun 3, 2022
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 3, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 3, 2022

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15597 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15597 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8632

Test results coming soon (I hope)...

Details

- notification for comment with ID 1145683945 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

branfosj
branfosj approved these changes Jun 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with merging this.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 3, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/059e977f2fcfe5a9bfea1e4ea6a528f2 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jun 3, 2022

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/8666d3756bdcf69a2f152cfe3135690a for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jun 3, 2022

Going in, thanks @boegel!

@branfosj branfosj merged commit e318a22 into easybuilders:develop Jun 3, 2022
@boegel boegel deleted the 20220603093650_new_pr_Arrow0160 branch June 3, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @branfosj