Skip to content

install sklearn meta-package with scikit-learn v1.0.1#15613

Merged
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20220604102108_new_pr_scikit-learn101
Jun 4, 2022
Merged

install sklearn meta-package with scikit-learn v1.0.1#15613
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20220604102108_new_pr_scikit-learn101

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jun 4, 2022 •
edited
Loading

(created using eb --new-pr)

So, in different easyconfigs we are solving the sklearn vs scikit-learn in different ways:

  • Annif, FMRIprep, NeuroKit, and panaro we install sklearn 0.0
  • cDNA_Cupcake, nnU-Net, pauvre, and scGeneFit do sed -i 's/sklearn/scikit-learn/g' setup.py

I am suggesting that we instead install sklearn with scikit-learn, allowing packages building on top of scikit-learn to be cleaner.

@branfosj branfosj mentioned this pull request Jun 4, 2022
Merged
boegel
boegel approved these changes Jun 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the 4.5.5 milestone Jun 4, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 4, 2022

@boegelbot please test @ generoso

@boegel boegel changed the title install sklearn meta-package with scikit-learn install sklearn meta-package with scikit-learn v1.0.1 Jun 4, 2022
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 4, 2022

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15613 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15613 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8654

Test results coming soon (I hope)...

Details

- notification for comment with ID 1146665818 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 4, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/c6fe8402fc62df76ecb5810bdef2588b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 4, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3108.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/782c5db247ce8ce56393f352261619d5 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 4, 2022

Going in, thanks @branfosj!

@boegel boegel merged commit 73b59b0 into easybuilders:develop Jun 4, 2022
@branfosj branfosj deleted the 20220604102108_new_pr_scikit-learn101 branch June 4, 2022 19:22
@boegel boegel mentioned this pull request Jun 9, 2022
Merged
@boegel boegel mentioned this pull request Mar 2, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

change

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegel @boegelbot