Skip to content

correct configopts in deal.II v9.1.1 easyconfig#15692

Merged
boegel merged 3 commits intoeasybuilders:developfrom
branfosj:20220615095552_new_pr_deal.II911
Jun 15, 2022
Merged

correct configopts in deal.II v9.1.1 easyconfig#15692
boegel merged 3 commits intoeasybuilders:developfrom
branfosj:20220615095552_new_pr_deal.II911

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jun 15, 2022

(created using eb --new-pr)

see #15690 (comment)

@branfosj
Copy link
Copy Markdown
Member Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=15692 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15692 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8721

Test results coming soon (I hope)...

Details

- notification for comment with ID 1156195574 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/87432b814d20d132399d59c033710567 for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

And correcting this leace deal.II failing to find some part of netCDF:

Include /tmp/boegelbot/dealII/9.1.1/intel-2019a/dealii-9.1.1/cmake/configure/configure_netcdf.cmake
-- NETCDF_INCLUDE_DIR not found! Call:
--     FIND_PATH(NETCDF_INCLUDE_DIR netcdfcpp.h HINTS /project/boegelbot/Rocky8/haswell/software/netCDF/4.6.2-iimpi-2019a PATH_SUFFIXES netcdf include)
-- NETCDF_CPLUSPLUS_LIBRARY not found! Call:
--     FIND_LIBRARY(NETCDF_CPLUSPLUS_LIBRARY NAMES netcdf_c++ netcdf_cpp HINTS /project/boegelbot/Rocky8/haswell/software/netCDF/4.6.2-iimpi-2019a PATH_SUFFIXES lib lib64 lib)
-- Found NETCDF_C_LIBRARY
--   NETCDF_LIBRARIES: *** Required variable "NETCDF_CPLUSPLUS_LIBRARY" set to NOTFOUND ***
--   NETCDF_INCLUDE_DIRS: *** Required variable "NETCDF_INCLUDE_DIR" set to NOTFOUND ***
-- Could NOT find NETCDF
-- DEAL_II_WITH_NETCDF has unmet external dependencies.
CMake Error at cmake/macros/macro_configure_feature.cmake:112 (MESSAGE):
  

  Could not find the netcdf library!

  Please ensure that a suitable netcdf library is installed on your computer.

  If the library is not at a default location, either provide some hints for
  autodetection,

      $ NETCDF_DIR="..." cmake <...>
      $ cmake -DNETCDF_DIR="..." <...>

  or set the relevant variables by hand in ccmake.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 15, 2022

@branfosj Yes, I ran into that as well...
Works fine if you just omit the configure options for netCDF, which I guess boils down to building deal.II without netCDF support (but we were doing that already, so it's not a regression).

It seems to want to old netCDF-C++ bindings?

@branfosj
Copy link
Copy Markdown
Member Author

@boegelbot please test @ generoso

@branfosj
Copy link
Copy Markdown
Member Author

@branfosj Yes, I ran into that as well... Works fine if you just omit the configure options for netCDF, which I guess boils down to building deal.II without netCDF support (but we were doing that already, so it's not a regression).

It seems to want to old netCDF-C++ bindings?

Yes, but I think it wants both netCDF and netCDF-C++ and we'd have to patch it to know that both are there but in separate places. So, I've remove the netCDF line from the configopts in 9427350

@boegelbot
Copy link
Copy Markdown
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=15692 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15692 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8722

Test results coming soon (I hope)...

Details

- notification for comment with ID 1156271332 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/693a1ba35d9b5ab2c03bdb4d4c9df669 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 15, 2022

@branfosj Yes, I ran into that as well... Works fine if you just omit the configure options for netCDF, which I guess boils down to building deal.II without netCDF support (but we were doing that already, so it's not a regression).
It seems to want to old netCDF-C++ bindings?

Yes, but I think it wants both netCDF and netCDF-C++ and we'd have to patch it to know that both are there but in separate places. So, I've remove the netCDF line from the configopts in 9427350

Makes sense, because whatever netCDF support that was there was removed recently anyway, see dealii/dealii#10387.
That explains why we're not seeing this problem with deal.II v9.3.3 in #15690, but it's weird that CMake doesn't trip over the -DDEAL_II_WITH_NETCDF=ON being used there then... 🤔

edit: Actually it does, but it just produces a warning:

CMake Warning:
  Manually-specified variables were not used by the project:

    DEAL_II_WITH_NETCDF
    NETCDF_DIR

I'll get rid of the *NETCDF* configure options in #15690

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@branfosj netCDF dependency should also be removed since -DDEAL_II_WITH_NETCDF=ON was removed

@branfosj
Copy link
Copy Markdown
Member Author

done in f65dd39

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 15, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15692 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15692 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8723

Test results coming soon (I hope)...

Details

- notification for comment with ID 1156407421 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/407f81354c5e42a90e6cf808c1f03193 for a full test report.

@boegel boegel changed the title correct configopts in deal.II correct configopts in deal.II v9.1.1 easyconfig Jun 15, 2022
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 15, 2022

Going in, thanks @branfosj!

@boegel boegel merged commit c1a1ae5 into easybuilders:develop Jun 15, 2022
@branfosj branfosj deleted the 20220615095552_new_pr_deal.II911 branch June 15, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants