Skip to content

{lib}[GCC/10.2.0] FSON v1.0.5#15721

Merged
jfgrimm merged 3 commits intoeasybuilders:developfrom
Helmholtz-UFZ:20220621112258_new_pr_FSON105
Jun 24, 2022
Merged

{lib}[GCC/10.2.0] FSON v1.0.5#15721
jfgrimm merged 3 commits intoeasybuilders:developfrom
Helmholtz-UFZ:20220621112258_new_pr_FSON105

Conversation

@DirectorSloan
Copy link
Copy Markdown
Contributor

@DirectorSloan DirectorSloan commented Jun 21, 2022

(created using eb --new-pr)

jfgrimm
jfgrimm requested changes Jun 21, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/f/FSON/FSON-1.0.5-foss-2020b.eb Outdated
@jfgrimm jfgrimm added this to the 4.x milestone Jun 21, 2022
@jfgrimm jfgrimm added the new label Jun 21, 2022
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jun 22, 2022

@boegelbot please test @ generoso

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jun 22, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
himem05.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6230 CPU @ 2.10GHz (cascadelake), Python 3.6.8
See https://gist.github.com/0572f3ca3e138a16779e1188a3b927e5 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jun 22, 2022

@DirectorSloan can you remove the foss version from this PR?

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 22, 2022

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=15721 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15721 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8756

Test results coming soon (I hope)...

Details

- notification for comment with ID 1163084021 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 22, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/0979d1f670abada80f8e5ce1b45017e7 for a full test report.

@DirectorSloan DirectorSloan requested a review from jfgrimm June 22, 2022 13:44
@DirectorSloan DirectorSloan changed the title {lib}[foss/2020b] FSON v1.0.5 {lib}[GCC/10.2.0] FSON v1.0.5 Jun 24, 2022
@DirectorSloan
Copy link
Copy Markdown
Contributor Author

DirectorSloan commented Jun 24, 2022

@DirectorSloan can you remove the foss version from this PR?

Renamed it (opened with eb --new-pr) Was this enough or did I miss something?

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jun 24, 2022

@DirectorSloan if you use --update-pr then you need to do e.g. eb --update-pr 15721 FSON-1.0.5-GCC-10.2.0.eb :FSON-1.0.5-foss-2020b.eb (prefixing the colon removes the file from the PR)
anyway, I've pushed a commit that removed the foss easyconfig

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jun 24, 2022

@boegelbot please test @ jsc-zen2

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jun 24, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
himem02.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/fe8e605c783fe4bffd04b35b003e2d62 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 24, 2022

@jfgrimm: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15721 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15721 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1329

Test results coming soon (I hope)...

Details

- notification for comment with ID 1165347507 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 24, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/f7bd3faa4c85506961de8d7155c294fa for a full test report.

jfgrimm
jfgrimm approved these changes Jun 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jun 24, 2022

Going in, thanks @DirectorSloan!

@jfgrimm jfgrimm merged commit f218a5c into easybuilders:develop Jun 24, 2022
@boegel boegel modified the milestones: 4.x, next release (4.5.6?) Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@DirectorSloan @jfgrimm @boegelbot @boegel