Skip to content

explicitly enable HDF5 from kallisto v0.46.2 onwards#15843

Merged
jfgrimm merged 2 commits intoeasybuilders:developfrom
SethosII:20220713092322_new_pr_kallisto0480
Jul 14, 2022
Merged

explicitly enable HDF5 from kallisto v0.46.2 onwards#15843
jfgrimm merged 2 commits intoeasybuilders:developfrom
SethosII:20220713092322_new_pr_kallisto0480

Conversation

@SethosII
Copy link
Copy Markdown
Contributor

@SethosII SethosII commented Jul 13, 2022 •
edited
Loading

(created using eb --new-pr)

As of the release notes for verion 0.46.2 support for HDF5 needs to be explicitly enabled in kallisto. Should I also include this in this EasyConfig: https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/k/kallisto/kallisto-0.46.2-foss-2020b.eb?

@SethosII SethosII changed the title Enable HDF5 Enable HDF5 in kallisto Jul 13, 2022
@jfgrimm jfgrimm added this to the next release (4.6.1?) milestone Jul 13, 2022
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 13, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node006.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/7ff8a8e25281769d0b908eda60a7be1b for a full test report.

@jfgrimm jfgrimm changed the title Enable HDF5 in kallisto explicitly enable HDF5 from kallisto v0.46.2 onwards Jul 13, 2022
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 13, 2022

Should I also include this in this EasyConfig: https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/k/kallisto/kallisto-0.46.2-foss-2020b.eb?

@SethosII yes please

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 13, 2022

pre-rebuild:

$ ldd $EBROOTKALLISTO/bin/kallisto | grep libhdf5
$

after:

$ ldd $EBROOTKALLISTO/bin/kallisto | grep libhdf5
	libhdf5.so.200 => /opt/apps/easybuild/software/HDF5/1.12.1-gompi-2021b/lib/libhdf5.so.200 (0x00007feafca1a000)
$

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 14, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 14, 2022

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=15843 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15843 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8866

Test results coming soon (I hope)...

Details

- notification for comment with ID 1184421576 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 14, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
gpu01.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), 1 x NVIDIA Tesla V100-SXM2-32GB, 510.47.03, Python 3.6.8
See https://gist.github.com/364abdae28670ed39d7b54cda721dfb0 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 14, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/9b2074ad15a25a82149bd07d8fe3943a for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 14, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 14, 2022

@jfgrimm: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15843 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15843 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1380

Test results coming soon (I hope)...

Details

- notification for comment with ID 1184434642 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 14, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/964573e34e67434dd9a78ed57180f5e3 for a full test report.

jfgrimm
jfgrimm approved these changes Jul 14, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 14, 2022

Going in, thanks @SethosII!

@jfgrimm jfgrimm merged commit 6013cfb into easybuilders:develop Jul 14, 2022
@SethosII SethosII deleted the 20220713092322_new_pr_kallisto0480 branch July 14, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix bug report

Projects

None yet

Milestone

4.6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@SethosII @jfgrimm @boegelbot