fix OpenBLAS 0.3.15 patch to correctly set the CPU core type for Tiger Lake#15845
fix OpenBLAS 0.3.15 patch to correctly set the CPU core type for Tiger Lake#15845akesandgren merged 3 commits intoeasybuilders:developfrom micaeljtoliveira:20220713201058_new_pr_OpenBLAS0315
Conversation
akesandgren
left a comment
There was a problem hiding this comment.
LGTM, patch matches changes from 0.3.15 to 0.3.18
|
@boegelbot Please test @ generoso |
|
@akesandgren: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 1232778622 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
The updated patch fails to apply to 0.3.12. |
|
@akesandgren Sorry for the long delay in addressing the problem with 0.3.12. I tried to fix the patch, but it seems that for it to actually work one would need to backport a lot more changes from later versions of OpenBLAS. So instead I just kept the current patch as it is for that version. Hope that's okay. |
|
Test report by @akesandgren |
|
@micaeljtoliveira Can you take a look at this, https://gist.github.com/sassy-crick/cc750a24bd1404c1c9a6f8a2c09c10aa ? Built on a "11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz" |
|
@akesandgren Not quite sure what to do about this. The issue with 0.3.12 is to be expected. As mentioned above, to fix it one would need to backport more fixes made in later versions of OpenBLAS. I tried to do that, but without much success: compilation what still broken even after including several more changes to the patch. Regarding the Lapack timing, that's a strange error, as I can't see any changes in the PR that could do that. |
|
Just wanted you to verify that it's what you'd expect for the 0.3.12 build. |
|
Going in, thanks @micaeljtoliveira! |
(created using
eb --new-pr)