Skip to content

add CVE patch for XZ 5.2.5 + attempt to fix symbol patch for all OSs#15856

Merged
boegel merged 2 commits intoeasybuilders:developfrom
ocaisa:20220713192927_new_pr_XZ525
Aug 12, 2022
Merged

add CVE patch for XZ 5.2.5 + attempt to fix symbol patch for all OSs#15856
boegel merged 2 commits intoeasybuilders:developfrom
ocaisa:20220713192927_new_pr_XZ525

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Jul 13, 2022 •
edited
Loading

Fixes #15846

(created using eb --new-pr)

@ocaisa ocaisa mentioned this pull request Jul 13, 2022
Closed
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Jul 13, 2022

This is (I believe) a safe patch as the 5.3 series is the current development version...but I have never seen a .map file before this PR!

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Jul 13, 2022

I need a victim to test this on CentOS 7

@ocaisa ocaisa mentioned this pull request Jul 13, 2022
Closed
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Jul 13, 2022

Test report by @ocaisa
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
login1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz, Python 3.6.8
See https://gist.github.com/4c4ec00e097b3c9a54f686ddf75b8be4 for a full test report.

ocaisa
ocaisa commented Jul 13, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/x/XZ/XZ-5.2.5_compat-libs.patch
lzma_cputhreads;
lzma_get_progress;
- lzma_stream_encoder_mt;
- lzma_stream_encoder_mt_memusage;
Copy link
Copy Markdown
Member Author

@ocaisa ocaisa Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The older patch did not remove these lines but then the linker throws some warnings about them already being declared in XZ_5.1.2alpha

ocaisa
ocaisa commented Jul 13, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/x/XZ/XZ-5.2.5_compat-libs.patch
-} XZ_5.0;
+} XZ_5.1.2alpha;
+
+XZ_5.2 {
Copy link
Copy Markdown
Member Author

@ocaisa ocaisa Jul 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the right way to do this but hopefully the idea is clear

@ocaisa ocaisa changed the title Add CVE patch, attempt to fix symbol patch for all OSes XZ-5.2.5: Add CVE patch, attempt to fix symbol patch for all OSes Jul 13, 2022
@deniskristak deniskristak mentioned this pull request Jul 14, 2022
Merged
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Jul 14, 2022

Confirmation in #14991 (comment) that new patch still solves the old problem on CentOS7

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 15, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 13 out of 13 (6 easyconfigs in total)
node029.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/e67047f54d5ac159b0f84ed34caf71c1 for a full test report.

@boegel boegel added the bug fix label Aug 3, 2022
@boegel boegel changed the title XZ-5.2.5: Add CVE patch, attempt to fix symbol patch for all OSes add CVE patch for XZ 5.2.5 + attempt to fix symbol patch for all OSs Aug 3, 2022
@boegel boegel added this to the next release (4.6.1?) milestone Aug 3, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 10, 2022

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3521.doduo.os - Linux RHEL 8.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/7c3776e5fe9b27299ff9aef4036984e1 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 10, 2022

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3703.slaking.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 3.6.8
See https://gist.github.com/26d43c31cf2866d3a080dcbab535ef3a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 11, 2022

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3703.slaking.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/e918f52f72af67a1e651a01a86cba46b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 12, 2022

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3521.doduo.os - Linux Ubuntu 20.04.4 LTS (Focal Fossa), x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.8.10
See https://gist.github.com/ab8c7818c8fd5f62dfe272f0f3b666bc for a full test report.

boegel
boegel approved these changes Aug 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on RHEL8, CentOS 7 and Ubuntu 20.04, looks good!

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 12, 2022

Going in, thanks @ocaisa!

@boegel boegel merged commit 8970dbe into easybuilders:develop Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.6.1

Development

Successfully merging this pull request may close these issues.

Patches for XZ 5.2.5

3 participants

@ocaisa @jfgrimm @boegel