Skip to content

use build enviroment set by EasyBuild and add missing dependency on zlib to minimap2#15859

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
lexming:20220714122523_new_pr_minimap2217
Jul 15, 2022
Merged

use build enviroment set by EasyBuild and add missing dependency on zlib to minimap2#15859
jfgrimm merged 1 commit intoeasybuilders:developfrom
lexming:20220714122523_new_pr_minimap2217

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Jul 14, 2022

(created using eb --new-pr)

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Jul 14, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 14, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=15859 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15859 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8864

Test results coming soon (I hope)...

Details

- notification for comment with ID 1184349300 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 14, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/44024b9ce50fcd2dab12645ce0b3b336 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 15, 2022

@boegelbot please test @ jsc-zen2

@jfgrimm jfgrimm added this to the 4.x milestone Jul 15, 2022
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 15, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node029.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/7b7487f2f367e74ce3b011afea358540 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 15, 2022

@jfgrimm: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15859 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15859 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1383

Test results coming soon (I hope)...

Details

- notification for comment with ID 1185393410 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 15, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/ad00acf790cccd2731d41501a3e8e8bb for a full test report.

@jfgrimm jfgrimm modified the milestones: 4.x, next release (4.6.1?) Jul 15, 2022
jfgrimm
jfgrimm approved these changes Jul 15, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 15, 2022

Going in, thanks @lexming!

@jfgrimm jfgrimm merged commit 722eb36 into easybuilders:develop Jul 15, 2022
@lexming lexming deleted the 20220714122523_new_pr_minimap2217 branch July 15, 2022 13:00
@boegel boegel changed the title use build enviroment from EB and add missing dependency on zlib to minimap2 use build enviroment set by EasyBuild and add missing dependency on zlib to minimap2 Sep 11, 2022
@boegel boegel mentioned this pull request Apr 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@lexming @boegelbot @jfgrimm