Skip to content

add missing dependencies and execute tests on Trycycler v0.5.2#15864

Merged
jfgrimm merged 2 commits intoeasybuilders:developfrom
lexming:20220714163624_new_pr_Trycycler052
Jul 15, 2022
Merged

add missing dependencies and execute tests on Trycycler v0.5.2#15864
jfgrimm merged 2 commits intoeasybuilders:developfrom
lexming:20220714163624_new_pr_Trycycler052

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Jul 14, 2022 •
edited by jfgrimm
Loading

@lexming lexming added this to the next release (4.6.1?) milestone Jul 14, 2022
@lexming lexming mentioned this pull request Jul 14, 2022
Merged
1 task
@boegelbot

This comment was marked as outdated.

Sign in to view
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 15, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 4 out of 4 (1 easyconfigs in total)
node029.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/98849e225f06e8303fbbaf2071ee4a83 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 15, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 15, 2022

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=15864 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15864 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8870

Test results coming soon (I hope)...

Details

- notification for comment with ID 1185411201 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 15, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/beaafea06e4255070a905a2d715346cb for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 15, 2022

@boegelbot please test @ jsc-zen2

jfgrimm
jfgrimm approved these changes Jul 15, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 15, 2022

@jfgrimm: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15864 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15864 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1385

Test results coming soon (I hope)...

Details

- notification for comment with ID 1185419615 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 15, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/63e34467f6378212c0ac6bba455f72a1 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jul 15, 2022

Going in, thanks @lexming!

@jfgrimm jfgrimm merged commit 09dba9c into easybuilders:develop Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@lexming @boegelbot @jfgrimm