Skip to content

{lib}[GCCcore/11.3.0] UCC-CUDA v1.0.0#15956

Merged
Micket merged 2 commits intoeasybuilders:developfrom
bartoldeman:20220802140049_new_pr_UCC-CUDA100
Aug 9, 2022
Merged

{lib}[GCCcore/11.3.0] UCC-CUDA v1.0.0#15956
Micket merged 2 commits intoeasybuilders:developfrom
bartoldeman:20220802140049_new_pr_UCC-CUDA100

Conversation

@bartoldeman
Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman commented Aug 2, 2022

(created using eb --new-pr)

@bartoldeman
adding easyconfigs: UCC-CUDA-1.0.0-GCCcore-11.3.0-CUDA-11.7.0.eb and …
7c2a642 
…patches: UCC-CUDA-1.0.0_link_against_existing_UCC_libs.patch
@bartoldeman bartoldeman added the new label Aug 2, 2022
@bartoldeman bartoldeman requested a review from Micket August 2, 2022 14:13
@bartoldeman
Copy link
Copy Markdown
Contributor Author

bartoldeman commented Aug 2, 2022

I used symlinks to avoid needing to patch the non-CUDA UCC. That's simple but a little different from the way UCX-CUDA does things.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 2, 2022 •
edited
Loading

I used symlinks to avoid needing to patch the non-CUDA UCC. That's simple but a little different from the way UCX-CUDA does things.

So, this would possible become and issue if we needed more UCC-xxx packages for additional plugins. I can only imagine that being the case for ROCM, which case you wouldn't have CUDA loaded simultaneously

@bartoldeman
Copy link
Copy Markdown
Contributor Author

bartoldeman commented Aug 2, 2022

UCC has no support for ROCM as far as I can see.
Configure only looks for NCCL, CUDA, UCX and SHARP, but SHARP is more os-level (IB related).

@bartoldeman
Copy link
Copy Markdown
Contributor Author

bartoldeman commented Aug 2, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 2, 2022

@bartoldeman: Request for testing this PR well received on login1

PR test command 'EB_PR=15956 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15956 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8936

Test results coming soon (I hope)...

Details

- notification for comment with ID 1202765232 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@bartoldeman
Copy link
Copy Markdown
Contributor Author

bartoldeman commented Aug 2, 2022

Test report by @bartoldeman
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
build-node.computecanada.ca - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.7.7
See https://gist.github.com/08367ad51aad03490e301434f2cfbb6e for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 2, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/19aff995899e59c4b959a346925aff4e for a full test report.

Micket
Micket reviewed Aug 2, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/u/UCC-CUDA/UCC-CUDA-1.0.0-GCCcore-11.3.0-CUDA-11.7.0.eb
@bartoldeman
Copy link
Copy Markdown
Contributor Author

bartoldeman commented Aug 3, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 3, 2022

@bartoldeman: Request for testing this PR well received on login1

PR test command 'EB_PR=15956 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15956 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8938

Test results coming soon (I hope)...

Details

- notification for comment with ID 1203984179 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 3, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/5b5291ada8dfcb9ccc1de1bf101047a0 for a full test report.

@bartoldeman bartoldeman added this to the next release (4.6.1?) milestone Aug 5, 2022
Micket
Micket approved these changes Aug 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 9, 2022

Test report by @Micket
SUCCESS
Build succeeded for 4 out of 4 (1 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/cdd81c1b367aa4d9d15a5aa3d857644d for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 9, 2022

Going in, thanks @bartoldeman!

@Micket Micket merged commit 5068509 into easybuilders:develop Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@bartoldeman @Micket @boegelbot