Skip to content

{lib}[GCCcore/11.2.0] json-fortran v8.3.0#15979

Merged
Micket merged 2 commits intoeasybuilders:developfrom
sassy-crick:20220805202439_new_pr_json-fortran830
Aug 9, 2022
Merged

{lib}[GCCcore/11.2.0] json-fortran v8.3.0#15979
Micket merged 2 commits intoeasybuilders:developfrom
sassy-crick:20220805202439_new_pr_json-fortran830

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

@sassy-crick sassy-crick commented Aug 5, 2022

(created using eb --new-pr)

@sassy-crick sassy-crick mentioned this pull request Aug 5, 2022
Merged
1 task
Micket
Micket requested changes Aug 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick look at the cmakelists.txt i found "USE_GNU_INSTALL_CONVENTION"
I think setting that would make it use the standard lib/ path instead, removing the need for modextrapaths

@Micket Micket added the new label Aug 6, 2022
@Micket Micket added this to the 4.x milestone Aug 6, 2022
@sassy-crick
Copy link
Copy Markdown
Collaborator Author

sassy-crick commented Aug 8, 2022

The reason I done that was as QuickPIX from PR #15978 uses that in one of their makefiles:

JSON_LIB = /usr/local/jsonfortran-gnu-6.3.0/lib/
JSON_INC = /usr/local/jsonfortran-gnu-6.3.0/lib/

So I took it as that is the 'default' way of installing the library and to make sure I am not breaking things too much, I opted for the modextrapath. Happy to change that and try your suggestion!

Micket
Micket approved these changes Aug 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (i think it's much cleaner like this, we don't need the extra paths to separate builds, since the module system takes care of that instead)

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 9, 2022

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/e51aac96362523da7ab0c37dfd9efab7 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 9, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 9, 2022

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=15979 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15979 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8968

Test results coming soon (I hope)...

Details

- notification for comment with ID 1209376584 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 9, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/1875d6b045a600cc0bd9e380845618fa for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 9, 2022

Going in, thanks @sassy-crick!

@Micket Micket modified the milestones: 4.x, next release (4.6.1?) Aug 9, 2022
@Micket Micket merged commit 7ef7ade into easybuilders:develop Aug 9, 2022
@sassy-crick sassy-crick deleted the 20220805202439_new_pr_json-fortran830 branch August 16, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@sassy-crick @Micket @boegelbot