Skip to content

fix dependency on FOX Toolkit in SUMO#15986

Merged
SebastianAchilles merged 2 commits intoeasybuilders:developfrom
lexming:20220807030302_new_pr_SUMO170
Aug 8, 2022
Merged

fix dependency on FOX Toolkit in SUMO#15986
SebastianAchilles merged 2 commits intoeasybuilders:developfrom
lexming:20220807030302_new_pr_SUMO170

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Aug 7, 2022 •
edited
Loading

(created using eb --new-pr)

The packageFoX is not related to the FOX toolkit needed by SUMO. This PR adds easyconfigs for the actual FOX toolkit and fixes the dependency in SUMO.

There is also a missing build dependency on Java and the homepage redirects to a new URL.

I'm also adding an updated easyconfig for the last release of SUMO v1.14.1

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Aug 7, 2022

@boegelbot: please test @ generoso

@lexming lexming mentioned this pull request Aug 7, 2022
Closed
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 7, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=15986 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15986 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8944

Test results coming soon (I hope)...

Details

- notification for comment with ID 1207308438 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 7, 2022

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 5 (5 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/f3441ecb5fdef898ba5639f6e5afee2b for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Aug 7, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 7, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=15986 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15986 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8946

Test results coming soon (I hope)...

Details

- notification for comment with ID 1207468717 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 7, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/a240a63d8c370864bd24ae934a40c6b6 for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Aug 8, 2022 •
edited
Loading

@boegelbot please test @ jsc-zen2
EB_ARGS="FOX-Toolkit-1.6.57-GCCcore-11.2.0.eb SUMO-1.12.0-foss-2021b.eb SUMO-1.14.1-foss-2021b.eb"

@SebastianAchilles SebastianAchilles added this to the 4.x milestone Aug 8, 2022
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 8, 2022

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15986 EB_ARGS="FOX-Toolkit-1.6.57-GCCcore-11.2.0.eb SUMO-1.12.0-foss-2021b.eb SUMO-1.14.1-foss-2021b.eb" /opt/software/slurm/bin/sbatch --job-name test_PR_15986 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1422

Test results coming soon (I hope)...

Details

- notification for comment with ID 1208106025 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 8, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/c0388be8ca658627cc5d6a459541b72a for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Aug 8, 2022

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bdw-opensuse-154 - Linux openSUSE Leap 15.4, x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.6.15
See https://gist.github.com/7ef49bb41b7e72d100b84ace4ce708a3 for a full test report.

SebastianAchilles
SebastianAchilles approved these changes Aug 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Aug 8, 2022

Going in, thanks @lexming!

@SebastianAchilles SebastianAchilles merged commit 0d97796 into easybuilders:develop Aug 8, 2022
@lexming lexming deleted the 20220807030302_new_pr_SUMO170 branch September 29, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

Assignees

No one assigned

Labels

bug fix new update

Projects

None yet

Milestone

4.6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@lexming @boegelbot @SebastianAchilles