Skip to content

add missing SciPy-bundle dependency for rMATS-turbo#15988

Merged
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
boegel:20220808104043_new_pr_rMATS-turbo411
Aug 8, 2022
Merged

add missing SciPy-bundle dependency for rMATS-turbo#15988
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
boegel:20220808104043_new_pr_rMATS-turbo411

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 8, 2022

(created using eb --new-pr)
Several rMATS_C/rMATS_P scripts require numpy, so SciPy-bundle should be included as dependency.
I couldn't find an easy way to catch this through a sanity check command though, since those scripts are not meant to be called directly...

@boegel boegel added the bug fix label Aug 8, 2022
@boegel boegel added this to the next release (4.6.1?) milestone Aug 8, 2022
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 8, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 8, 2022

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15988 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15988 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8948

Test results coming soon (I hope)...

Details

- notification for comment with ID 1207857159 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 8, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/aca6fed7909838880eedc9cde311faa9 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 8, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in total)
node3131.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/c12d9483e082bc0dfe48ab058295ce85 for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Aug 8, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 8, 2022

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15988 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15988 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1415

Test results coming soon (I hope)...

Details

- notification for comment with ID 1207961389 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 8, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/29103b2cbcbf4dc5d3dc2bc7ae5f3eff for a full test report.

SebastianAchilles
SebastianAchilles approved these changes Aug 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Aug 8, 2022

Going in, thanks @boegel!

@SebastianAchilles SebastianAchilles merged commit ceb8238 into easybuilders:develop Aug 8, 2022
@boegel boegel deleted the 20220808104043_new_pr_rMATS-turbo411 branch August 8, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @SebastianAchilles