Skip to content

remove unecessary patch in recent JupyterLab#16030

Merged
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
branfosj:20220811115908_new_pr_JupyterLab228
Aug 11, 2022
Merged

remove unecessary patch in recent JupyterLab#16030
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
branfosj:20220811115908_new_pr_JupyterLab228

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Aug 11, 2022 •
edited
Loading

(created using eb --new-pr)

In these easyconfigs we set

modextravars = {'JUPYTERLAB_DIR': '%(installdir)s/share/jupyter/lab'}

With that set the patch is not needed, as the JUPYTERLAB_DIR environment variable is preferred, when it is set, over the patched code path.

The patch I removing here patches the code at https://github.com/jupyterlab/jupyterlab/blob/master/jupyterlab/commands.py#L153

@branfosj branfosj added this to the next release (4.6.1?) milestone Aug 11, 2022
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Aug 11, 2022

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
bear-pg0104u03b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/957c1d27406869fe25c807f0410edd01 for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Aug 11, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 11, 2022

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16030 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16030 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1452

Test results coming soon (I hope)...

Details

- notification for comment with ID 1212095713 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Aug 11, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 11, 2022

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=16030 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16030 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9003

Test results coming soon (I hope)...

Details

- notification for comment with ID 1212100075 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 11, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (4 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/265324f0fcc7b574f2fce91900e07434 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 11, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/fb3f199ec09481dee854936139a10462 for a full test report.

SebastianAchilles
SebastianAchilles approved these changes Aug 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Aug 11, 2022

Going in, thanks @branfosj!

@SebastianAchilles SebastianAchilles merged commit 2f0607d into easybuilders:develop Aug 11, 2022
@branfosj branfosj deleted the 20220811115908_new_pr_JupyterLab228 branch August 11, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

Assignees

No one assigned

Labels

code cleanup

Projects

None yet

Milestone

4.6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @SebastianAchilles @boegelbot