Skip to content

add pigz dependency for cutadapt v3.4 + v3.5#16056

Merged
Micket merged 1 commit intoeasybuilders:developfrom
SethosII:20220818104510_new_pr_cutadapt34
Aug 18, 2022
Merged

add pigz dependency for cutadapt v3.4 + v3.5#16056
Micket merged 1 commit intoeasybuilders:developfrom
SethosII:20220818104510_new_pr_cutadapt34

Conversation

@SethosII
Copy link
Copy Markdown
Contributor

@SethosII SethosII commented Aug 18, 2022 •
edited
Loading

(created using eb --new-pr)

pigz is not strictly a dependency but used if available. From what I've found this was added in version 1.15. Should I also add this to older easyconfigs?

@SethosII SethosII changed the title add pigz as dependency cutadapt: add pigz as dependency Aug 18, 2022
Micket
Micket approved these changes Aug 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added this to the next release (4.6.1?) milestone Aug 18, 2022
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 18, 2022

i think just these versions suffices

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 18, 2022

@boegelbot please test @ generoso

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 18, 2022

Test report by @Micket
SUCCESS
Build succeeded for 12 out of 12 (3 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/1a86b71d5d81f756374ca17d60115b27 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 18, 2022

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=16056 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16056 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9027

Test results coming soon (I hope)...

Details

- notification for comment with ID 1219721324 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 18, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/7090d8e291c7e299bf184f8f625d78e8 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 18, 2022

Going in, thanks @SethosII!

@Micket Micket merged commit d56c2a0 into easybuilders:develop Aug 18, 2022
@SethosII SethosII deleted the 20220818104510_new_pr_cutadapt34 branch August 19, 2022 06:20
@boegel boegel changed the title cutadapt: add pigz as dependency add pigz dependency for cutadapt v3.4 + v3.5 Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@SethosII @Micket @boegelbot