make check for toolchain value in dependency spec in easyconfigs test suite aware that dumped easyconfig uses SYSTEM constant#16126
Merged
Micket merged 2 commits intoeasybuilders:developfrom Aug 26, 2022
Conversation
… suite aware that dumped easyconfig uses SYSTEM constant
Member
Author
|
The tests for this PR will fail until easybuilders/easybuild-framework#4069 is merged, but this PR will need to get merged ASAP after the merging of easybuilders/easybuild-framework#4069 to avoid broken tests in PRs being opened... |
1 task
This comment was marked as outdated.
This comment was marked as outdated.
Micket
previously requested changes
Aug 26, 2022
use `cond is True` instead of `cond == True` Co-authored-by: Mikael Öhman <[email protected]>
jfgrimm
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires: