Skip to content

{tools}[GCC/11.3.0] plotutils v2.6#16196

Merged
boegel merged 6 commits intoeasybuilders:developfrom
sassy-crick:20220905221847_new_pr_plotutils26
Oct 23, 2023
Merged

{tools}[GCC/11.3.0] plotutils v2.6#16196
boegel merged 6 commits intoeasybuilders:developfrom
sassy-crick:20220905221847_new_pr_plotutils26

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

@sassy-crick sassy-crick commented Sep 5, 2022

Comment thread easybuild/easyconfigs/p/plotutils/plotutils-2.6-GCC-11.3.0.eb
sassy-crick pushed a commit to sassy-crick/easybuild-easyconfigs that referenced this pull request Mar 2, 2023
@sassy-crick
Copy link
Copy Markdown
Collaborator Author

I gave all of that some thought and of course, you are right: moving gawk to GCCcore is a better way forward. So I done that (PR #17454) and updated the relevant PRs for this project.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 23, 2023

I gave all of that some thought and of course, you are right: moving gawk to GCCcore is a better way forward. So I done that (PR #17454) and updated the relevant PRs for this project.

I guess you could argue both ways, but since we already have a bunch of gawk easyconfigs using GCC as toolchain, it's better to stick to that and also use GCC for this (new) plotutils, and likewise for #15950 that in turns depends on this.

So, I will:

Sorry for the back and forth and the confusion here @sassy-crick :)

Comment thread easybuild/easyconfigs/p/plotutils/plotutils-2.6-GCCcore-11.3.0.eb Outdated
@boegel boegel mentioned this pull request Oct 23, 2023
3 tasks
@easybuilders easybuilders deleted a comment from boegelbot Oct 23, 2023
@easybuilders easybuilders deleted a comment from boegelbot Oct 23, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 23, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16196 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_16196 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12029

Test results coming soon (I hope)...

Details

- notification for comment with ID 1775783866 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 23, 2023

@boegelbot please test @ jsc-zen2

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 23, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3100.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/1766ad294eac3eee8fbb867064d4ec17 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/412669e5231828eaf059e7d3d91cf91b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 23, 2023

@boegelbot please test @ generoso
EB_ARGS="--sanity-check-only"

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 23, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3100.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/e186dcd614e67823b8884f0792eff052 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16196 EB_ARGS="--sanity-check-only" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_16196 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12032

Test results coming soon (I hope)...

Details

- notification for comment with ID 1775932252 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/441765bee10e3cf699291c9ad6e722bd for a full test report.

@boegel boegel added this to the next release (4.8.2?) milestone Oct 23, 2023
@boegel boegel added the new label Oct 23, 2023
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 23, 2023

Going in, thanks @sassy-crick!

@boegel boegel merged commit 0d834b0 into easybuilders:develop Oct 23, 2023
@sassy-crick sassy-crick deleted the 20220905221847_new_pr_plotutils26 branch October 23, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants