{vis} [intel-2015a] ParaView 4.3.1 (REVIEW) #1627
{vis} [intel-2015a] ParaView 4.3.1 (REVIEW) #1627boegel merged 14 commits intoeasybuilders:developfrom
Conversation
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3078/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3205/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3739/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3741/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
normally, we would add python etc, but this is just too much 😉
There was a problem hiding this comment.
well, if Python is a dep (and other deps also use Python), it's good practice to include -Python-<version> in the versionsuffix
|
lgtm |
There was a problem hiding this comment.
yeah but, if you do python, why not the others?
-Python-2.7.10-GLib-2.44.0-libX11-1.6.3
It's ugly but either we stick with the rule or we don't
There was a problem hiding this comment.
because Python is a very common dep, it helps users identifying which modules are compatible with each other
the others are far less common, so listing everything in the versionsuffix yields no added benefit, it just makes things uglier
it's a pragmatic choice
There was a problem hiding this comment.
problem is, if you really mean it to be consistent with all, it is needed also to add build modes/flags, opt options etc; we merely end up with a hash function of some build configuration. See, #1689 for another variation of this issue/need. The faster we agree that this is simply a hash of the build setup, the sooner we'll come to agreement about what it should look like.
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4611/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4614/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
@boegel made it python-2.7.10, but I find a bit ridicolous, like |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4616/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
Weird, it works here. |
|
@wpoely86: it's just because |
|
Test report by @boegel |
|
Test report by @boegel |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4661/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4664/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@boegel: there are two ways to solve the problems:
Problems are usually cannot connect, do not find file, etc. In the test phase many files are downloaded, and sometimes their server is too busy. I am in favor of 1, because compiling already takes forever. |
|
@hajgato: pre-downloading the files needed for the test (sequentially rather than in parallel) is not an option? Can you update the PR to disable testing (option 1), and include a clear comment why you disable testing? |
|
@boegel the If this work, then I will implememt the same for |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4734/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
please add a comment here why you include is, and mention why you use the ; (i.e., to allow this command to fail, and trigger a 2nd try via make)
|
Test report by @boegel |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4736/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@boegel %% fixed, extra comment added for |
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @hajgato! |
{vis} [intel-2015a] ParaView 4.3.1 (REVIEW)
Needs
#1618