Skip to content

[gcc-4.9.2] fixed git to include EB perl and path (REVIEW)#1631

Merged
boegel merged 2 commits intoeasybuilders:developfrom
rjeschmi:eb-git
Jun 3, 2015
Merged

[gcc-4.9.2] fixed git to include EB perl and path (REVIEW)#1631
boegel merged 2 commits intoeasybuilders:developfrom
rjeschmi:eb-git

Conversation

@rjeschmi
Copy link
Copy Markdown
Contributor

@rjeschmi rjeschmi commented May 22, 2015

Some of git, especially the submodules code, is written in Perl.

I had some problems with the base version of perl included in centos6, so it makes some sense to use the version of perl available in EB.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented May 22, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3094/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3094/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel
boegel reviewed May 22, 2015
View reviewed changes
Comment thread easybuild/easyconfigs/g/git/git-2.4.1-GCC-4.9.2.eb Outdated
Copy link
Copy Markdown
Member

@boegel boegel May 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style remark: please move this up below the sources/source_urls` (also in the other git 2.x easyconfig you're touching in this PR)

@boegel
Copy link
Copy Markdown
Member

boegel commented May 22, 2015

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/12d5bbf1765685fa3445 for a full test report.

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Jun 3, 2015

Still waiting for style update as requested by @boegel otherwise good to go

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Jun 3, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3322/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3322/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@rjeschmi
Copy link
Copy Markdown
Contributor Author

rjeschmi commented Jun 3, 2015

I believe I've resolved the style comments, thanks @ocaisa @boegel

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 3, 2015

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/a1f0411a86d8d8e27bb2 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 3, 2015

Thanks @rjeschmi, and @ocaisa for reviewing, going in!

boegel added a commit that referenced this pull request Jun 3, 2015
@boegel
Merge pull request #1631 from rjeschmi/eb-git
3652daa 
[gcc-4.9.2] fixed git to include EB perl and path (REVIEW)
@boegel boegel merged commit 3652daa into easybuilders:develop Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rjeschmi @hpcugentbot @boegel @ocaisa