add multi-dep exception to easyconfigs test suite for ncbi-vdb-3.0.0 which requires HDF5 1.10.x#16316
Merged
casparvl merged 3 commits intoeasybuilders:developfrom Oct 11, 2022
Merged
Conversation
casparvl
approved these changes
Oct 11, 2022
Contributor
casparvl
left a comment
There was a problem hiding this comment.
Looks good to me. Next time, it's probably best to put the multidep exception and the PR for the software to which it applies (ncbi-cdb-3.0.0) in the same PR. That way we can actually see that it works in the CI of said software.
For now, I've just checked the change real carefully and assume that it works, and we should be able to see this immediately in #16376 . But if it doesn't, we'd have to roll back this PR, which would be a bit annoying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add ncbi-vdb 3.0.0 to test/easyconfigs/easyconfigs.py multidep execption for HDF5 1.10.x
required for #16376