Skip to content

add missing pkg-config build dependency to Guile#16317

Merged
smoors merged 3 commits intoeasybuilders:developfrom
fizwit:20220926153653_new_pr_Guile307
Oct 1, 2022
Merged

add missing pkg-config build dependency to Guile#16317
smoors merged 3 commits intoeasybuilders:developfrom
fizwit:20220926153653_new_pr_Guile307

Conversation

@fizwit
Copy link
Copy Markdown
Contributor

@fizwit fizwit commented Sep 26, 2022

(created using eb --new-pr)

@jfgrimm jfgrimm changed the title missing pkg-config add missing pkg-config builddep to Guile Sep 27, 2022
@jfgrimm jfgrimm added this to the 4.x milestone Sep 27, 2022
@jfgrimm jfgrimm mentioned this pull request Sep 27, 2022
Merged
smoors
smoors reviewed Sep 28, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/g/Guile/Guile-3.0.7-GCCcore-11.2.0.eb Outdated
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 1, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 1, 2022

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=16317 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16317 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9228

Test results coming soon (I hope)...

Details

- notification for comment with ID 1264266373 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 1, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/2898e20b8fad8b1b4f773a4ba85de97f for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 1, 2022

Test report by @smoors
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in total)
node301.hydra.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/a474510e80cc2b24179ae874c56a1e84 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Oct 1, 2022
@smoors smoors modified the milestones: 4.x, next release (4.6.2?) Oct 1, 2022
smoors
smoors approved these changes Oct 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 1, 2022

Going in, thanks @fizwit!

@smoors smoors merged commit 7f92976 into easybuilders:develop Oct 1, 2022
@boegel boegel changed the title add missing pkg-config builddep to Guile add missing pkg-config build dependency to Guile Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.6.2

Development

Successfully merging this pull request may close these issues.

4 participants

@fizwit @smoors @boegelbot @jfgrimm