Skip to content

add missing pkg-config build dependency for recent p11-kit easyconfigs#16318

Merged
boegel merged 4 commits intoeasybuilders:developfrom
fizwit:20220926155017_new_pr_p11-kit0241
Jan 14, 2024
Merged

add missing pkg-config build dependency for recent p11-kit easyconfigs#16318
boegel merged 4 commits intoeasybuilders:developfrom
fizwit:20220926155017_new_pr_p11-kit0241

Conversation

@fizwit
Copy link
Copy Markdown
Contributor

@fizwit fizwit commented Sep 26, 2022

(created using eb --new-pr)

@jfgrimm jfgrimm changed the title missing pkg-config builddep add missing pkg-config builddep to p11-kit Sep 27, 2022
@jfgrimm jfgrimm added this to the 4.x milestone Sep 27, 2022
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Sep 27, 2022

@fizwit could you also add pkg-config to p11-kit-0.24.0-GCCcore-10.3.0.eb?

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Sep 27, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
login1.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/38d446761d317637b73ae219de882182 for a full test report.

@boegel boegel changed the title add missing pkg-config builddep to p11-kit add missing pkg-config build dependency for recent p11-kit easycofnigs Jan 13, 2024
@boegel boegel changed the title add missing pkg-config build dependency for recent p11-kit easycofnigs add missing pkg-config build dependency for recent p11-kit easyconfigs Jan 13, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 13, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 13, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16318 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_16318 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12599

Test results coming soon (I hope)...

Details

- notification for comment with ID 1890754535 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 13, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2fa8444e858989cecb599e52584c0593 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 13, 2024

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (3 easyconfigs in total)
node3135.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/a5d084d4e5ee4df6ad18a326a9fa91dd for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 13, 2024

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 13, 2024

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16318 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_16318 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4075

Test results coming soon (I hope)...

Details

- notification for comment with ID 1890764354 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 14, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/3a4d992c0bad5102270e407ae0bf9adb for a full test report.

@boegel boegel modified the milestones: 4.x, release after 4.9.0 Jan 14, 2024
boegel
boegel approved these changes Jan 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 14, 2024

Going in, thanks @fizwit!

@boegel boegel merged commit 9074e18 into easybuilders:develop Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

4 participants

@fizwit @jfgrimm @boegel @boegelbot