Skip to content

add missing build dep pkg-config to enchant-2#16319

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
fizwit:20220926162232_new_pr_enchant-2233
Sep 27, 2022
Merged

add missing build dep pkg-config to enchant-2#16319
jfgrimm merged 1 commit intoeasybuilders:developfrom
fizwit:20220926162232_new_pr_enchant-2233

Conversation

@fizwit
Copy link
Copy Markdown
Contributor

@fizwit fizwit commented Sep 26, 2022

(created using eb --new-pr)

@jfgrimm jfgrimm changed the title missing build dep pkg-config add missing build dep pkg-config to enchant-2 Sep 27, 2022
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Sep 27, 2022

@boegelbot please test @ generoso

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Sep 27, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
login1.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/2334c4983a798a95b474ff111c95f88a for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 27, 2022

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=16319 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16319 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9205

Test results coming soon (I hope)...

Details

- notification for comment with ID 1259235111 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 27, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/20eb183eae8cec250468f3571d35e345 for a full test report.

@jfgrimm jfgrimm added this to the next release (4.6.2?) milestone Sep 27, 2022
jfgrimm
jfgrimm approved these changes Sep 27, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Sep 27, 2022

Going in, thanks @fizwit!

@jfgrimm jfgrimm merged commit 104d44c into easybuilders:develop Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.6.2

Development

Successfully merging this pull request may close these issues.

3 participants

@fizwit @jfgrimm @boegelbot