Skip to content

{lib}[foss/2021a] torchdata v0.3.0 w/ Python 3.9.5 + CUDA 11.3.1#16344

Merged
Micket merged 9 commits intoeasybuilders:developfrom
VRehnberg:torchdata
Oct 19, 2022
Merged

{lib}[foss/2021a] torchdata v0.3.0 w/ Python 3.9.5 + CUDA 11.3.1#16344
Micket merged 9 commits intoeasybuilders:developfrom
VRehnberg:torchdata

Conversation

@VRehnberg
Copy link
Copy Markdown
Contributor

Found no existing issue connected to this.

Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filename needs to include version suffix -CUDA-11.3.1 as well

Going forward with PyTorch, we should definitely bundle this component with the normal PyTorch, as it would be much cleaner, less messy suffixes and such.

In fact, we can consider just updating the PyTorch easyconfig themselves to add this extension.
It's one of the few in-place changes we can do to modules without concern since EB allows for a very simple eb --skip --rebuild Foo.eb that only builds any missing extensions.

Comment thread easybuild/easyconfigs/t/torchdata-0.3.0-PyTorch-1.11.0.eb Outdated
Comment thread easybuild/easyconfigs/t/torchdata-0.3.0-PyTorch-1.11.0.eb Outdated
Comment thread easybuild/easyconfigs/t/torchdata-0.3.0-PyTorch-1.11.0.eb Outdated
@Micket Micket added the new label Sep 30, 2022
@boegel boegel added this to the 4.x milestone Oct 4, 2022
@boegel boegel changed the title add recipe for torchdata 0.3.0 {lib}[foss/2021a] torchdata v0.3.0 Oct 4, 2022
@boegelbot

This comment was marked as resolved.

@VRehnberg
Copy link
Copy Markdown
Contributor Author

@boegel I've added the checksum. Should I do anything else to alert your bot?

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 6, 2022

nope. bot responds when it sees finished CI (since it's your first PR, we have to manually start it)

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 6, 2022

 /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/t/torchdata/torchdata-0.3.0-foss-2021a-PyTorch-1.11.0-CUDA-11.3.1.eb:9:121: E501 line too long (154 > 120 characters)

hint: eb --check-style Foo-1.2.3.eb

@boegelbot

This comment was marked as resolved.

@VRehnberg
Copy link
Copy Markdown
Contributor Author

It still says requesting changes, but as far as I can tell all requested changes are resolved?

Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 14, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=16344 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16344 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9288

Test results coming soon (I hope)...

Details

- notification for comment with ID 1279144473 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/35e1b19c3bd31be01f40004f92c52358 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 19, 2022

Going in, thanks @VRehnberg!

@Micket Micket merged commit 8e86c2b into easybuilders:develop Oct 19, 2022
@boegel boegel modified the milestones: 4.x, next release (4.6.2?) Oct 19, 2022
@boegel boegel changed the title {lib}[foss/2021a] torchdata v0.3.0 {lib}[foss/2021a] torchdata v0.3.0 w/ Python 3.9.5 + CUDA 11.3.1 Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants