Skip to content

{lib}[foss/2021a] DeepLabCut v2.2.0.6 w/ Python 3.9.5#16391

Merged
casparvl merged 11 commits intoeasybuilders:developfrom
sassy-crick:20221012141255_new_pr_DeepLabCut2206
Nov 1, 2022
Merged

{lib}[foss/2021a] DeepLabCut v2.2.0.6 w/ Python 3.9.5#16391
casparvl merged 11 commits intoeasybuilders:developfrom
sassy-crick:20221012141255_new_pr_DeepLabCut2206

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

@sassy-crick sassy-crick commented Oct 12, 2022

Comment on lines +18 to +19
('CUDA', '11.3.1', '', True),
('cuDNN', '8.2.1.32', '-CUDA-%(cudaver)s', True),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
('CUDA', '11.3.1', '', True),
('cuDNN', '8.2.1.32', '-CUDA-%(cudaver)s', True),
('CUDA', '11.3.1', '', SYSTEM),
('cuDNN', '8.2.1.32', '-CUDA-%(cudaver)s', SYSTEM),

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That slipped through. I have changed that.

Copy link
Copy Markdown
Member

@jfgrimm jfgrimm Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sassy-crick your latest commit has reverted back to True

'sources': ['%(name)s-%(version)s.zip'],
'checksums': ['4f2a4d39e4ea601b9ab42b2db08b5918a9538c168cff1c6895ae26646f3d73b1'],
}),
('pandas', '1.3.3', {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we bundle pandas in SciPy-bundle, is there a need for a version newer than 1.2.4?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably no need, most likely I did not know and I was thus looking for the latest version of it. I have removed it and it is still building. Thanks for pointing that out.

@casparvl
Copy link
Copy Markdown
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
gcn2 - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz, 4 x NVIDIA NVIDIA A100-SXM4-40GB, 515.43.04, Python 3.6.8
See https://gist.github.com/e36fe7607c8a9a0e3d74642be011e7c0 for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
software2.lisa.surfsara.nl - Linux debian 10.13, x86_64, Intel(R) Xeon(R) Bronze 3104 CPU @ 1.70GHz, 4 x NVIDIA NVIDIA TITAN V, 470.103.01, Python 3.7.3
See https://gist.github.com/5d7d379e53a7628a58748e17b8b49f61 for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=16391 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16391 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9301

Test results coming soon (I hope)...

Details

- notification for comment with ID 1280898231 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Copy Markdown
Contributor

Test report by @casparvl
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
software2.lisa.surfsara.nl - Linux debian 10.13, x86_64, Intel(R) Xeon(R) Bronze 3104 CPU @ 1.70GHz, 4 x NVIDIA NVIDIA TITAN V, 470.103.01, Python 3.7.3
See https://gist.github.com/39fcce90b63911270131bbeb014085f7 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 2 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/c9adb5fed1c6053119a90ac6987e7b20 for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

Test report by @casparvl
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
gcn2.local.snellius.surf.nl - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz, 4 x NVIDIA NVIDIA A100-SXM4-40GB, 515.43.04, Python 3.6.8
See https://gist.github.com/9c4671f9f308b0c35c5096b8d4d8626e for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

From the pip sanity check:

== 2022-10-17 16:01:53,979 build_log.py:169 ERROR EasyBuild crashed with an error (at easybuild/RHEL8/2022/software/EasyBuild/4.6.1/lib/python3.6/site-packages/easybuild/base/exceptions.py:124 in __init__): `pip check` failed:
deeplabcut 2.2.0.6 requires moviepy, which is not installed.
deeplabcut 2.2.0.6 has requirement scikit-image<=0.18.1,>=0.17, but you have scikit-image 0.18.3.

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

From the pip sanity check:

== 2022-10-17 16:01:53,979 build_log.py:169 ERROR EasyBuild crashed with an error (at easybuild/RHEL8/2022/software/EasyBuild/4.6.1/lib/python3.6/site-packages/easybuild/base/exceptions.py:124 in __init__): `pip check` failed:
deeplabcut 2.2.0.6 requires moviepy, which is not installed.
deeplabcut 2.2.0.6 has requirement scikit-image<=0.18.1,>=0.17, but you have scikit-image 0.18.3.

Thanks for finding this, entirely my wrong as I did not rebuild after I added the sanity_pip_check = True. I have added the missing MoviePy and also downgraded scikit-image. To avoid (hopefully) any conflicts, I have installed scikit-image as an extension, rather than as a module. If that is the wrong way forward, please let me know. I was hoping that extensions might be the better way here.
I have also updated PR #16281 regarding this.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 24, 2022

@sassy-crick take a look at: DeepLabCut/DeepLabCut#1791, DeepLabCut/DeepLabCut#1800

we can probably get away with just using the scikit-image version we have in an easyconfig, and loosening the upper version bound in requirements.txt

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

@sassy-crick take a look at: DeepLabCut/DeepLabCut#1791, DeepLabCut/DeepLabCut#1800

we can probably get away with just using the scikit-image version we have in an easyconfig, and loosening the upper version bound in requirements.txt

Done. I am always a bit cautious to changing upper bounds but it builds ok.

I have also reverted the True back to System, which happened accidentally.

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Nov 1, 2022

Test report by @casparvl
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
gcn1.local.snellius.surf.nl - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz, 4 x NVIDIA NVIDIA A100-SXM4-40GB, 515.43.04, Python 3.6.8
See https://gist.github.com/a4115ec75e873ccafd53bc72c63f472a for a full test report.

Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@casparvl casparvl added the new label Nov 1, 2022
@casparvl casparvl added this to the next release (4.6.3?) milestone Nov 1, 2022
@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Nov 1, 2022

Test report by @casparvl
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
software2.lisa.surfsara.nl - Linux debian 10.13, x86_64, Intel(R) Xeon(R) Bronze 3104 CPU @ 1.70GHz, 4 x NVIDIA NVIDIA TITAN V, 470.103.01, Python 3.7.3
See https://gist.github.com/c26d821f54b769ce6bab582bce553b5f for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Nov 1, 2022

Going in, thanks @sassy-crick!

@casparvl casparvl merged commit f307351 into easybuilders:develop Nov 1, 2022
@sassy-crick sassy-crick deleted the 20221012141255_new_pr_DeepLabCut2206 branch November 1, 2022 15:32
@easybuilders easybuilders deleted a comment from boegelbot Dec 27, 2022
@easybuilders easybuilders deleted a comment from boegelbot Dec 27, 2022
@easybuilders easybuilders deleted a comment from boegelbot Dec 27, 2022
@easybuilders easybuilders deleted a comment from boegelbot Dec 27, 2022
@easybuilders easybuilders deleted a comment from boegelbot Dec 27, 2022
@easybuilders easybuilders deleted a comment from boegelbot Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants