Skip to content

fix using provided Qhull and freetype dependencies for matplotlib 3.5.2 by creating mplsetup.cfg rather than setup.cfg#16396

Merged
branfosj merged 2 commits intoeasybuilders:developfrom
smoors:20221012185405_new_pr_matplotlib352
Oct 13, 2022
Merged

fix using provided Qhull and freetype dependencies for matplotlib 3.5.2 by creating mplsetup.cfg rather than setup.cfg#16396
branfosj merged 2 commits intoeasybuilders:developfrom
smoors:20221012185405_new_pr_matplotlib352

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Oct 12, 2022

(created using eb --new-pr)

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Oct 12, 2022 •
edited
Loading

discovered this due to the following error while installing matplotlib:

      error: Failed to download any of the following: ['http://www.qhull.org/download/qhull-2020-src-8.0.2.tgz'].  Please download one of these urls and extract it into 'build/' at the top-level of the source repository.
      [end of output]
··
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

 Encountered error while trying to install package.
> matplotlib

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Oct 12, 2022

@boegelbot: please test @ generoso

@smoors smoors added the bug fix label Oct 12, 2022
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 12, 2022

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=16396 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16396 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9269

Test results coming soon (I hope)...

Details

- notification for comment with ID 1276473763 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 12, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/289e0f6080e4cfdc53f9b860ef766730 for a full test report.

@smoors smoors added this to the next release (4.6.2?) milestone Oct 12, 2022
@smoors smoors mentioned this pull request Oct 13, 2022
Closed
3 tasks
@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Oct 13, 2022

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node301.hydra.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/0d8b80a5473c4576ef96ac32190c49aa for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Oct 13, 2022

This also needs changing in matplotlib-3.5.2-intel-2022a.eb?

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Oct 13, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 13, 2022

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=16396 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16396 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9271

Test results coming soon (I hope)...

Details

- notification for comment with ID 1277288818 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 13, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/5d285144d5d7b30caf33235beb04b76c for a full test report.

branfosj
branfosj approved these changes Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Oct 13, 2022

Test report by @branfosj
SUCCESS
Build succeeded for 6 out of 6 (2 easyconfigs in total)
bear-pg0105u36b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/f15c262983a8dc26b0868b5cdc28e397 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Oct 13, 2022

Going in, thanks @smoors!

@branfosj branfosj merged commit 8c56cc6 into easybuilders:develop Oct 13, 2022
@boegel boegel changed the title fix using system qhull and freetype for matplotlib fix using provided qhull and freetype dependencies for matplotlib 3.5.2 by creating mplsetup.cfg rather than setup.cfg Oct 19, 2022
@boegel boegel changed the title fix using provided qhull and freetype dependencies for matplotlib 3.5.2 by creating mplsetup.cfg rather than setup.cfg fix using provided Qhull and freetype dependencies for matplotlib 3.5.2 by creating mplsetup.cfg rather than setup.cfg Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.6.2

Development

Successfully merging this pull request may close these issues.

3 participants

@smoors @boegelbot @branfosj