Skip to content

{data}[system/system] AMAPVox v1.9.4 (Java)#16438

Merged
jfgrimm merged 2 commits intoeasybuilders:developfrom
boegel:20221019085212_new_pr_AMAPVox194
Oct 20, 2022
Merged

{data}[system/system] AMAPVox v1.9.4 (Java)#16438
jfgrimm merged 2 commits intoeasybuilders:developfrom
boegel:20221019085212_new_pr_AMAPVox194

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 19, 2022

(created using eb --new-pr)

@boegel boegel added the new label Oct 19, 2022
@boegel boegel added this to the 4.x milestone Oct 19, 2022
@boegel boegel mentioned this pull request Oct 19, 2022
Closed
2 tasks
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 19, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node109.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/3e8e1fadf6a91aec5c6d560aae14de54 for a full test report.

jfgrimm
jfgrimm requested changes Oct 19, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/a/AMAPVox/AMAPVox-1.9.4-Java-11.eb Outdated
Comment thread easybuild/easyconfigs/a/AMAPVox/AMAPVox-1.9.4-Java-11.eb Outdated
@boegel @jfgrimm
Apply suggestions from code review
8ace4cc 
don't hardcode version in sanity_check_paths for AMAPVox + use SOURCE_ZIP template in sources

Co-authored-by: Jasper <[email protected]>
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 19, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 19, 2022

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16438 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16438 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9320

Test results coming soon (I hope)...

Details

- notification for comment with ID 1284406838 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 19, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns5 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/964ad6e13b390a71a4ff4990536c0dc8 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 20, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node151.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/b558b39ab94cb672a878e5a3a18ed2e5 for a full test report.

@jfgrimm jfgrimm modified the milestones: 4.x, release after 4.6.2 Oct 20, 2022
jfgrimm
jfgrimm approved these changes Oct 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 20, 2022

Going in, thanks @boegel!

@jfgrimm jfgrimm merged commit b8ecf9a into easybuilders:develop Oct 20, 2022
@boegel boegel deleted the 20221019085212_new_pr_AMAPVox194 branch October 20, 2022 09:38
@boegel boegel changed the title {data}[system/system] AMAPVox v1.9.4 {data}[system/system] AMAPVox v1.9.4 (Java) Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.6.2

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @jfgrimm @boegelbot