Skip to content

enable building of dev tools in recent PyQt5 easyconfigs#16469

Merged
jfgrimm merged 4 commits intoeasybuilders:developfrom
ThomasHoffmann77:20221021170908_new_pr_PyQt55154
Oct 26, 2022
Merged

enable building of dev tools in recent PyQt5 easyconfigs#16469
jfgrimm merged 4 commits intoeasybuilders:developfrom
ThomasHoffmann77:20221021170908_new_pr_PyQt55154

Conversation

@ThomasHoffmann77
Copy link
Copy Markdown
Contributor

@ThomasHoffmann77 ThomasHoffmann77 commented Oct 21, 2022

(created using eb --new-pr)

@ThomasHoffmann77 ThomasHoffmann77 mentioned this pull request Oct 21, 2022
Merged
ThomasHoffmann77 added a commit to ThomasHoffmann77/easybuild-easyconfigs that referenced this pull request Oct 21, 2022
@ThomasHoffmann77
Delete PyQt5-5.15.4-GCCcore-10.3.0-tools.eb
07e39d0 
see easybuilders#16469
@jfgrimm jfgrimm changed the title build missing tool pyrcc5 enable building of dev tools in PyQt5 Oct 24, 2022
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 24, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node115.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/ac0e9bfd31cb7c5d89fa8d0d9fb4e4ac for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 24, 2022

@ThomasHoffmann77 can we add a sanity check command for pyrcc5 as well? maybe something like pyrcc5 -version | grep 'pyrcc5 v%(version)s' or similar

if you're up for porting the changes to the other recent-ish easyconfigs as well, that would be great:

  • PyQt5-5.15.1-GCCcore-9.3.0-Python-3.8.2.eb
  • PyQt5-5.15.1-GCCcore-10.2.0.eb
  • PyQt5-5.15.4-GCCcore-10.2.0.eb
  • PyQt5-5.15.4-GCCcore-10.3.0.eb

@jfgrimm jfgrimm added this to the 4.x milestone Oct 24, 2022
@ThomasHoffmann77
Update PyQt5-5.15.4-GCCcore-11.2.0.eb
9042e64 
add sanity check commands for pyuic5, pylupdate5, and pyrcc5
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Oct 25, 2022

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/9c3fb3cad566e6cc8b5b62aa85821381 for a full test report.

@ThomasHoffmann77
@jfgrimm added sanity check commands for tools pyuic5, pylupdate5, an…
d2341f4 
…d pyrcc5; port changes to recent-ish easyconfigs.
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 25, 2022

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 25, 2022

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=16469 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16469 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9349

Test results coming soon (I hope)...

Details

- notification for comment with ID 1290724691 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 25, 2022

Test report by @jfgrimm
FAILED
Build succeeded for 6 out of 7 (4 easyconfigs in total)
node006.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/3866e9626284f8ae2fa10ff4576a1aeb for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 25, 2022

error from the one failed build:

    30 Usage: python configure.py [options]                                                                                    
    31                                                                                                                         
    32 configure.py: error: '/users/jfg508/scratch/easybuild-dev/software/PyQt5/5.15.1-GCCcore-9.3.0-Python-3.8.2/share/sip' is not a directory

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Oct 25, 2022

Test report by @verdurin
FAILED
Build succeeded for 5 out of 6 (4 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/67e41275e10ef6705f5e7e3092cc51c2 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 25, 2022 •
edited
Loading

@ThomasHoffmann77 maybe just remove the 5.15.1 one from this PR

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 25, 2022

Test report by @boegelbot
FAILED
Build succeeded for 3 out of 4 (4 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/259cac319a032b51af3ff8959698ee6b for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 26, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 26, 2022

@jfgrimm: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16469 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16469 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1728

Test results coming soon (I hope)...

Details

- notification for comment with ID 1291657338 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@jfgrimm jfgrimm changed the title enable building of dev tools in PyQt5 enable building of dev tools in recent PyQt5 easyconfigs Oct 26, 2022
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 26, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node124.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/68e0fd9ea19348f4a8e3f1f4aa9826d0 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 26, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/4384ba685b03cc04527c81007495457d for a full test report.

jfgrimm
jfgrimm approved these changes Oct 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 26, 2022

Going in, thanks @ThomasHoffmann77!

@jfgrimm jfgrimm merged commit 85e349f into easybuilders:develop Oct 26, 2022
@jfgrimm jfgrimm modified the milestones: 4.x, next release (4.6.3?) Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ThomasHoffmann77 @jfgrimm @verdurin @boegelbot