Skip to content

also define $JUPYTER_CONFIG_PATH in IPython and JupyterLab easyconfigs#16556

Merged
boegel merged 2 commits intoeasybuilders:developfrom
lexming:20221104170521_new_pr_IPython7250
Dec 9, 2022
Merged

also define $JUPYTER_CONFIG_PATH in IPython and JupyterLab easyconfigs#16556
boegel merged 2 commits intoeasybuilders:developfrom
lexming:20221104170521_new_pr_IPython7250

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Nov 4, 2022 •
edited
Loading

(created using eb --new-pr)

JUPYTER_CONFIG_PATH has to be populated with all etc/jupyter folders. The config files in there are needed to initialize any notebook extensions.
See https://docs.jupyter.org/en/latest/use/jupyter-directories.html#envvar-JUPYTER_CONFIG_PATH

@lexming lexming added the bug fix label Nov 4, 2022
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Nov 4, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 4, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16556 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16556 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9426

Test results coming soon (I hope)...

Details

- notification for comment with ID 1303816699 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 4, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/e43e7fc1c5ce3f1d9108bb809b1e3fd2 for a full test report.

@lexming lexming force-pushed the 20221104170521_new_pr_IPython7250 branch from 89508a8 to 4662a1d Compare November 5, 2022 10:35
@lexming lexming force-pushed the 20221104170521_new_pr_IPython7250 branch from 4662a1d to 96505b3 Compare November 5, 2022 10:43
@lexming lexming changed the title set JUPYTER_CONFIG_PATH in IPython populate JUPYTER_CONFIG_PATH in IPython and JupyterLab Nov 5, 2022
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Nov 5, 2022

Updated to also include JupyterLab

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Nov 5, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 5, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16556 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16556 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9443

Test results coming soon (I hope)...

Details

- notification for comment with ID 1304495265 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 5, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/2c8818e5fa4844e0e3a1156a407072c0 for a full test report.

@lexming lexming mentioned this pull request Nov 7, 2022
Closed
1 task
@boegel boegel changed the title populate JUPYTER_CONFIG_PATH in IPython and JupyterLab also define $JUPYTER_CONFIG_PATH in IPython and JupyterLab easyconfigs Dec 9, 2022
@boegel boegel added this to the next release (4.7.0) milestone Dec 9, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 9, 2022

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3103.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/3966e002743db032b751a1a8cefc0e2c for a full test report.

boegel
boegel approved these changes Dec 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 9, 2022

Going in, thanks @lexming!

@boegel boegel merged commit efb4268 into easybuilders:develop Dec 9, 2022
@lexming lexming deleted the 20221104170521_new_pr_IPython7250 branch December 9, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lexming @boegelbot @boegel