{chem,lib,vis}[gomkl/2021a] mcu v2021-04-06, matplotlib v3.4.2, spglib-python v1.16.1 w/ Python 3.9.5#16566
Conversation
…l-2021a.eb, spglib-python-1.16.1-gomkl-2021a.eb
|
Test report by @PetrKralCZ |
| easyblock = 'PythonPackage' | ||
|
|
||
| name = 'MCU' | ||
| version = '3366c85' # There is a 0.2 release but it's too old and it doesn't work |
There was a problem hiding this comment.
@PetrKralCZ Don't use commit IDs as versions directly, since they don't sort.
Use a datestamp (date that the commit was created) as version instead, like this:
local_commit = '3366c85'
version = '2021-04-06'
...
sources = [{'download_filename': '%s.tar.gz' % local_commit, 'filename': SOURCE_TAR_GZ}]| download_dep_fail = True | ||
| sanity_pip_check = True | ||
|
|
||
| options = {'modulename': 'mcu'} |
There was a problem hiding this comment.
This line should not be required, so please remove it.
The PythonPackage easyblock will do an import test with the lowercase software name by default (see output of eb --trace when installing the easyconfig).
| @@ -0,0 +1,33 @@ | |||
| easyblock = 'PythonPackage' | |||
|
|
|||
| name = 'MCU' | |||
There was a problem hiding this comment.
Based on https://hungqpham.com/mcu/index.html, it looks like mcu (lowercase) is the most commonly used "spelling" of the software name, so stick to that.
|
@boegelbot please test @ generoso |
|
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 1306855198 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @boegel |
|
Going in, thanks @PetrKralCZ! |
(created using
eb --new-pr)