Skip to content

{bio}[GCC/10.3.0] InParanoid v5.0.79d8e39#16572

Merged
boegel merged 3 commits intoeasybuilders:developfrom
sib-swiss:20221107175024_new_pr_InParanoid5079d8e39
Nov 9, 2022
Merged

{bio}[GCC/10.3.0] InParanoid v5.0.79d8e39#16572
boegel merged 3 commits intoeasybuilders:developfrom
sib-swiss:20221107175024_new_pr_InParanoid5079d8e39

Conversation

@SIB-software
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@smoretti smoretti added new BioHack2022 Related to EU BioHackathon 2022 labels Nov 7, 2022
"%(installdir)s/inparanoid.pl && "
"perl -i -pe 's|\./\$blastParser|\$blastParser|g' "
"%(installdir)s/inparanoid.pl && "
"perl -i -pe 's|#!.*perl|#!/usr/bin/env perl|' %(installdir)s/*.pl"]
Copy link
Copy Markdown
Member

@boegel boegel Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably makes sense to make these separate commands, since that way we can more easily tell which command fails (if that happens).
Also, we typically use sed -i rather than perl -i -pe:

postinstallcmds = [
    "rm -rf %(installdir)s/docker/ %(installdir)s/singularity/",
    "chmod a+rx %(installdir)s/*.pl",
    "chmod -x %(installdir)s/*.jar",
    "sed -i 's|helpfile = \"help\"|helpfile = \"%(installdir)s/help\"|' %(installdir)s/inparanoid.pl",
    ...,
]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also use fix_perl_shebang_for = ['*.pl'] instead of the perl -i -pe 's|#!.*perl|#!/usr/bin/env perl|' %(installdir)s/*.pl command

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perl is a requirement, that's why I used it instead of sed. I can change for sed if you want.

How to do separate accounts in the postinstallcmds ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postinstallcmds is a list of strings; see boegel's example above

}

sanity_check_commands = ["inparanoid.pl -input-dir %(installdir)s/testInput/ && "
"rm -Rf %(installdir)s/output/"]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about running this in the build directory instead, then cleanup is not needed:

sanity_check_commands = [
    "cd %(builddir)s && inparanoid.pl -input-dir %(installdir)s/testInput/",
]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense


sanity_check_paths = {
'files': ['inparanoid.pl', 'blast_parser.pl', 'diamondParser.pl'],
'dirs': ['matrices'],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check for testInput here?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right

@jfgrimm jfgrimm added this to the 4.x milestone Nov 8, 2022
…ut/ exists + Test outside of the install dir
toolchain = {'name': 'GCC', 'version': '10.3.0'}

source_urls = ['https://bitbucket.org/sonnhammergroup/inparanoid/get/']
sources = ['79d8e39bb243d403ce57b699c1ae104a8a640389.tar.gz']
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoretti We should rename this on download:

version = '5.0.79d8e39'
local_commit = '79d8e39bb243d403ce57b699c1ae104a8a640389'
...
sources = [{'download_filename': '%s.tar.gz' % local_commit, 'filename': SOURCE_TAR_GZ}]

easyblock = 'Tarball'

name = 'InParanoid'
version = '5.0.79d8e39'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoretti I only notice now that this is a self-invented version...

I think it would be better to ensure we use a version that sorts well, so use a datestamp of the commit instead?

version = '5.0-20220607`

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 9, 2022

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
node3135.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/7c3ba25d816759e5b590bf658a7f85e7 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 9, 2022

Going in, thanks @SIB-software!

@boegel boegel merged commit 9e59ba9 into easybuilders:develop Nov 9, 2022
@boegel boegel modified the milestones: 4.x, next release (4.6.3?) Nov 9, 2022
@smoretti smoretti deleted the 20221107175024_new_pr_InParanoid5079d8e39 branch November 9, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BioHack2022 Related to EU BioHackathon 2022 new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants