{bio}[system/system] Godon v20210913 (x86_64)#16574
{bio}[system/system] Godon v20210913 (x86_64)#16574boegel merged 3 commits intoeasybuilders:developfrom
Conversation
| toolchain = SYSTEM | ||
|
|
||
| source_urls = ['https://bitbucket.org/Davydov/godon/downloads'] | ||
| sources = ['godon-master-linux-gnu-x86_64'] |
There was a problem hiding this comment.
No versioned download? :-/
At the very least, let EasyBuild rename the file on download, something like:
sources = [{
'download_filename': 'godon-master-linux-gnu-x86_64',
'filename': 'godon-%(version)s-linux-gnu-x86_64',
}]It's much better to use a download URL or filename that includes a version though, if that's available, since otherwise the download will be broken due to getting a different checksum if there's an update...
There was a problem hiding this comment.
the source code is available too (it's written in Go), so we could look at a from-source build too. Looks like it relies on NLOpt and a BLAS implementation
There was a problem hiding this comment.
I tried to compile it several times, but it always failed in my hands, as most Go packages do.
There was a problem hiding this comment.
There is no version for the binary download, that's why I used the last change date
There was a problem hiding this comment.
Building from source would indeed be better, but the versionsuffix makes it very clear we're using a pre-built binary here, so no blocker to merge this
|
|
||
| extract_sources = False | ||
|
|
||
| postinstallcmds = ["mkdir -p %(installdir)s/bin/ && cd %(installdir)s/bin/ && " |
| sources = ['godon-master-linux-gnu-x86_64'] | ||
| checksums = ['159058f7577093548f3ced1540d1ff9fd5f7915cdfcb8f8cd7fb40f5c202fcca'] | ||
|
|
||
|
|
There was a problem hiding this comment.
Please remove duplicate empty line
|
|
||
| sanity_check_paths = { | ||
| 'files': ["bin/godon"], | ||
| 'dirs': ['bin'], |
There was a problem hiding this comment.
There's no point in checking for a non-empty bin directory if we're already checking for a specific file in there, so:
sanity_check_paths = {
'files': ["bin/godon"],
'dirs': [],
}| source_urls = ['https://bitbucket.org/Davydov/godon/downloads'] | ||
| sources = [{ | ||
| 'download_filename': 'godon-master-linux-gnu-x86_64', | ||
| 'filename': 'godon', |
There was a problem hiding this comment.
@smoretti You should definitely use %(version)s here, and probably also keep the x86_64 part, and then change install_cmd accordingly below:
sources = [{
'download_filename': 'godon-master-linux-gnu-x86_64',
'filename': 'godon-%(version)s-linux-gnu-x86_64',
}]
...
install_cmd = "mkdir -p %(installdir)s/bin/ && cp -a godon-%(version)s-linux-gnu-x86_64 %(installdir)s/bin/ && "
install_cmd += "cd %(installdir)s/bin && ln -s godon-%(version)s-linux-gnu-x86_64 godon"Also use cp -a rather than mv, so you don't remove the downloaded file while installing
There was a problem hiding this comment.
@boegel You mean also to change the version value "20210913" to "master"?
There was a problem hiding this comment.
sources = [{
'download_filename': 'godon-master-linux-gnu-x86_64',
'filename': 'godon-%(version)s-linux-gnu-x86_64',
}]
will download the godon-master-linux-gnu-x86_64 file and save it as godon-%(version)s-linux-gnu-x86_64
|
@boegelbot please test @ generoso |
|
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 1308323523 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @boegel |
|
Going in, thanks @SIB-software! |
(created using
eb --new-pr)