Skip to content

{bio}[foss/2021a] NanoLyse v1.2.1 w/ Python 3.9.5#16575

Merged
boegel merged 3 commits intoeasybuilders:developfrom
sib-swiss:20221108101819_new_pr_NanoLyse121
Nov 9, 2022
Merged

{bio}[foss/2021a] NanoLyse v1.2.1 w/ Python 3.9.5#16575
boegel merged 3 commits intoeasybuilders:developfrom
sib-swiss:20221108101819_new_pr_NanoLyse121

Conversation

@SIB-software
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@smoretti smoretti added new BioHack2022 Related to EU BioHackathon 2022 labels Nov 8, 2022
Comment on lines +21 to +26
('CMake', '3.20.1'),
('make', '4.3'),
('Check', '0.15.2'),
('SWIG', '4.0.2'),
('expat', '2.2.9'),
('bzip2', '1.0.8'),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these really all needed?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these as build dependency don't make much sense, like bzip2 and zlib...

Comment on lines +39 to +41
('mappy', '2.24', {
'checksums': ['35a2fb73ef14173283d5abb31e7a318429e0330c3be95851df38dd83d4ff9af9'],
}),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe mappy requires minimap2, so that should be a dependency. Given that the mappy releases match the minimap2 releases, I would say the versions should be the same as well

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a minimap2.py script in the install bin/

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will check for minimap2

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from what I remember, mappy just provides a python wrapper that calls out to minimap2

@boegel boegel added this to the 4.x milestone Nov 8, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 9, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16575 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16575 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9459

Test results coming soon (I hope)...

Details

- notification for comment with ID 1308325121 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/7b8467c8cc386a19763440399431b3ec for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.6.3?) Nov 9, 2022
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 9, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3135.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/3c74414daf430878c2a7d0e911973f55 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 9, 2022

Going in, thanks @SIB-software!

@boegel boegel merged commit 93acf5d into easybuilders:develop Nov 9, 2022
@smoretti smoretti deleted the 20221108101819_new_pr_NanoLyse121 branch November 9, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BioHack2022 Related to EU BioHackathon 2022 new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants