{bio}[GCC/10.3.0] CAT-BAT v5.2.3 w/ Python 3.9.5#16577
{bio}[GCC/10.3.0] CAT-BAT v5.2.3 w/ Python 3.9.5#16577boegel merged 3 commits intoeasybuilders:developfrom
Conversation
| sources = ['v%(version)s.tar.gz'] | ||
| checksums = ['19a8eb28c0ebd3fc5a04b006d305a916dd1af00a32b70d2f30df35f32ca2929b'] | ||
|
|
||
| builddependencies = [('binutils', '2.36.1')] |
There was a problem hiding this comment.
binutils is not required when using GCC as toolchain (only required when using GCCcore toolchain)
| postinstallcmds = ["cd %(installdir)s/ && ln -s CAT_pack bin && " | ||
| "chmod a+rx %(installdir)s/CAT_pack/*.py && " | ||
| "sed -i 's@/usr/bin/env/ python3@/usr/bin/env python3@' " | ||
| "%(installdir)s/CAT_pack/check.py"] |
There was a problem hiding this comment.
Please use separate commands (easier to tell which command failed if one of them fails):
postinstallcmds = [
"cd %(installdir)s/ && ln -s CAT_pack bin",
"chmod a+rx %(installdir)s/CAT_pack/*.py",
"sed -i 's@/usr/bin/env/ python3@/usr/bin/env python3@' %(installdir)s/CAT_pack/check.py",
]BTW, that last sed commands doesn't actually change anything?
| } | ||
|
|
||
| modextrapaths = { | ||
| 'PATH': '', |
There was a problem hiding this comment.
if CAT is in the CAT_pack subdir, this seems wrong?
…useless PATH extension
| postinstallcmds = [ | ||
| "cd %(installdir)s/ && ln -s CAT_pack bin", | ||
| "chmod a+rx %(installdir)s/CAT_pack/*.py", | ||
| "sed -i 's@/usr/bin/env/ python3@/usr/bin/env python3@' %(installdir)s/CAT_pack/check.py", |
There was a problem hiding this comment.
@smoretti Let's add a comment on top here to clarify what this does, because it's too easy to overlook:
| "sed -i 's@/usr/bin/env/ python3@/usr/bin/env python3@' %(installdir)s/CAT_pack/check.py", | |
| # fix shebang in check.py script ('/env/' should be '/env') | |
| "sed -i 's@/usr/bin/env/ python3@/usr/bin/env python3@' %(installdir)s/CAT_pack/check.py", |
|
@boegelbot please test @ generoso |
| ] | ||
|
|
||
| sanity_check_paths = { | ||
| 'files': ['CAT_pack/CAT', 'README.md'], |
There was a problem hiding this comment.
Maybe also check for bin/CAT here, to verify the symlink that we put in place (it also helps point out why modextrapaths is not needed to make the sanity check command work)
|
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 1308327020 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @boegel |
|
Going in, thanks @SIB-software! |
(created using
eb --new-pr)