Skip to content

{tools}[GCCcore/11.3.0] resolos v0.3.5 w/ Python 3.10.4#16649

Merged
lexming merged 6 commits intoeasybuilders:developfrom
garadar:20221115150430_new_pr_resolos035
Nov 21, 2022
Merged

{tools}[GCCcore/11.3.0] resolos v0.3.5 w/ Python 3.10.4#16649
lexming merged 6 commits intoeasybuilders:developfrom
garadar:20221115150430_new_pr_resolos035

Conversation

@garadar
Copy link
Copy Markdown
Contributor

@garadar garadar commented Nov 15, 2022

(created using eb --new-pr)

lexming
lexming requested changes Nov 18, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/r/resolos/resolos-0.3.5.eb Outdated
Comment thread easybuild/easyconfigs/r/resolos/resolos-0.3.5.eb Outdated
@lexming lexming added the new label Nov 18, 2022
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 21, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16649 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16649 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9597

Test results coming soon (I hope)...

Details

- notification for comment with ID 1321860416 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/45aa0ad1dd9f1163d33af3b0d3708098 for a full test report.

@boegelbot

This comment was marked as outdated.

Sign in to view
@lexming lexming changed the title {data}[system/] resolos v0.3.5 {tools}[GCCcore/11.3.0] resolos v0.3.5 w/ Python 3.10.4 Nov 21, 2022
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 21, 2022 •
edited
Loading

@garadar Thanks for the update. I converted this easyconfig from a PythonPackage to a PythonBundle. Effectively this does not change the installation of resolos, but we are standardizing installations of Python modules around PythonBundle and it automatically fixes the failed test.

You can see the differences in 92a83bf

@boegelbot

This comment was marked as outdated.

Sign in to view
lexming
lexming requested changes Nov 21, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/r/resolos/resolos-0.3.5-GCCcore-11.3.0.eb
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 21, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16649 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16649 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9613

Test results coming soon (I hope)...

Details

- notification for comment with ID 1322148803 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2022

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/1e37f74e3eb2b19d1822268cd4cd4193 for a full test report.

lexming
lexming requested changes Nov 21, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/r/resolos/resolos-0.3.5-GCCcore-11.3.0.eb
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 21, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16649 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16649 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9615

Test results coming soon (I hope)...

Details

- notification for comment with ID 1322284843 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/ab1af53f0e19531dd66652153c0badf2 for a full test report.

lexming
lexming approved these changes Nov 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garadar thanks for keeping up with my requests

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 21, 2022

Going in, thanks @garadar !

@lexming lexming merged commit bd4a6fe into easybuilders:develop Nov 21, 2022
@lexming lexming added this to the next release (4.6.3?) milestone Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@garadar @lexming @boegelbot