Skip to content

{lib}[foss/2022a] lagrangian-filtering v0.8.3 w/ Python 3.10.4#16654

Merged
lexming merged 6 commits intoeasybuilders:developfrom
sassy-crick:20221115173008_new_pr_lagrangian-filtering083
Dec 14, 2022
Merged

{lib}[foss/2022a] lagrangian-filtering v0.8.3 w/ Python 3.10.4#16654
lexming merged 6 commits intoeasybuilders:developfrom
sassy-crick:20221115173008_new_pr_lagrangian-filtering083

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

@sassy-crick sassy-crick commented Nov 15, 2022 •
edited
Loading

@boegelbot

This comment was marked as outdated.

Sign in to view
lexming
lexming requested changes Nov 18, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/l/lagrangian-filtering/lagrangian-filtering-0.8.3-foss-2022a.eb Outdated
Comment thread easybuild/easyconfigs/l/lagrangian-filtering/lagrangian-filtering-0.8.3-foss-2022a.eb Outdated
Comment thread easybuild/easyconfigs/l/lagrangian-filtering/lagrangian-filtering-0.8.3-foss-2022a.eb Outdated
lexming
lexming reviewed Nov 18, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/l/lagrangian-filtering/lagrangian-filtering-0.8.3-foss-2022a.eb Outdated
@boegelbot

This comment was marked as outdated.

Sign in to view
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 21, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16654 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16654 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9610

Test results coming soon (I hope)...

Details

- notification for comment with ID 1322035866 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

lexming
lexming reviewed Nov 21, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/l/lagrangian-filtering/lagrangian-filtering-0.8.3-foss-2022a.eb Outdated
@lexming lexming added the new label Nov 21, 2022
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns4 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/4ee6cb88bfec5f2b17063ee087432782 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Dec 14, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 14, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16654 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16654 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9760

Test results coming soon (I hope)...

Details

- notification for comment with ID 1350791056 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 14, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/c79f19658f1cb85c136aaaa5bf172e03 for a full test report.

lexming
lexming approved these changes Dec 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sassy-crick I cleaned up even more dependencies provided by Parcels

LGTM

@lexming lexming added this to the next release (4.7.0) milestone Dec 14, 2022
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Dec 14, 2022

Going in, thanks @sassy-crick !

@lexming lexming merged commit 6c7a549 into easybuilders:develop Dec 14, 2022
@sassy-crick sassy-crick deleted the 20221115173008_new_pr_lagrangian-filtering083 branch December 14, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm left review comments

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sassy-crick @boegelbot @lexming @jfgrimm