Skip to content

add UDUNITS#167

Merged
boegel merged 7 commits intoeasybuilders:developfrom
fgeorgatos:contrib_UDUNITS
Apr 28, 2013
Merged

add UDUNITS#167
boegel merged 7 commits intoeasybuilders:developfrom
fgeorgatos:contrib_UDUNITS

Conversation

@fgeorgatos
Copy link
Copy Markdown
Contributor

I think this should be the last PR for this month :)

Signed-off-by: Fotis Georgatos [email protected]

Signed-off-by: Fotis Georgatos <[email protected]>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No proper toolchain?

If this tool is actually compiled in any way (i.e. if it's more than simply provided headers or scripts), you really need to use a proper toolchain.

Please clarify.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error, now fixed.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 27, 2013

@fgeorgatos: Some UDUNITS easyconfigs were included with #211. The goalf and goolf ones are already there, your ictce ones are not.

Can you merge in develop to make this mergeable again, and sync up all the UDUNITS easyconfigs if required? I think it's mostly sanity_check_paths and moduleclass you'll have to take a look at...

@fgeorgatos
Copy link
Copy Markdown
Contributor Author

done, ready

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your adding you as an author in an easyconfig I created? :P

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add me as an author as well.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Classic quote from Ken Thompson:
"My only mis-coordination with Dennis Ritchie was that we once created the same sourcefile, whereby they matched byte to byte"
We hit one more of this case I think, and our files differed by a slash only, save for the sanity_cheks & parallel :-P

Anyway, now we are ready for this merge, all headers are aligned and both of us are co-authors. Shoot!

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 28, 2013

Tested all of them on my end, works great.

boegel added a commit that referenced this pull request Apr 28, 2013
@boegel boegel merged commit 71dc4ea into easybuilders:develop Apr 28, 2013
@fgeorgatos fgeorgatos deleted the contrib_UDUNITS branch April 29, 2013 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants