Skip to content

.eb file to install GenotypeHarmonizer 1.4.14 with java 1.7.80#1672

Merged
boegel merged 5 commits intoeasybuilders:developfrom
npklein:GenotypeHarmonizer-1.4.14
Jun 5, 2015
Merged

.eb file to install GenotypeHarmonizer 1.4.14 with java 1.7.80#1672
boegel merged 5 commits intoeasybuilders:developfrom
npklein:GenotypeHarmonizer-1.4.14

Conversation

@npklein
Copy link
Copy Markdown
Contributor

@npklein npklein commented Jun 5, 2015

No description provided.

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 5, 2015

Jenkins: ok to test

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this on top please, first line (and blank line above name)

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 5, 2015

@npklein: some minor style remarks, looks pretty good for your first contribution! Welcome to EasyBuild!

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3421/
Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3421/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 5, 2015

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/90fbf003e823a0f8f856 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 5, 2015

@npklein: our test bot detected an issue with your filename:

AssertionError: Filename '.../GenotypeHarmonizer-1.4.14-Java-1.7.0_80.eb' of parsed easyconfig matches expected filename 'GenotypeHarmonizer-1.4.14.eb'

versionsuffix is not set, see https://github.com/hpcugent/easybuild-easyconfigs/blob/master/easybuild/easyconfigs/a/ant/ant-1.9.3-Java-1.7.0_79.eb#L15 for example

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3427/
Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3427/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3428/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3428/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3430/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3430/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toolchain should go below description, with an empty line above/below

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3434/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3434/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 5, 2015

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/77b75ed85dc2f2043c1e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 5, 2015

Looking good now, going on.

Congrats on your first contribution to EasyBuild @npklein!

Welcome to the wonderful world of EasyBuild... ;-)

boegel added a commit that referenced this pull request Jun 5, 2015
.eb file to install GenotypeHarmonizer 1.4.14 with java 1.7.80
@boegel boegel merged commit fb1ec01 into easybuilders:develop Jun 5, 2015
@npklein npklein deleted the GenotypeHarmonizer-1.4.14 branch June 17, 2015 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants