Skip to content

{lib}[gompi/2021a] HighFive v2.6.2#16737

Merged
lexming merged 4 commits intoeasybuilders:developfrom
guacke:20221124165326_new_pr_HighFive262
Dec 19, 2022
Merged

{lib}[gompi/2021a] HighFive v2.6.2#16737
lexming merged 4 commits intoeasybuilders:developfrom
guacke:20221124165326_new_pr_HighFive262

Conversation

@guacke
Copy link
Copy Markdown
Contributor

@guacke guacke commented Nov 24, 2022

(created using eb --new-pr)

@guacke guacke mentioned this pull request Nov 24, 2022
Closed
@boegelbot

This comment was marked as outdated.

Sign in to view
@lexming lexming added the new label Dec 10, 2022
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Dec 10, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 10, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16737 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16737 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9733

Test results coming soon (I hope)...

Details

- notification for comment with ID 1344931120 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 10, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/88073fcb730c83629b215fe2b1882f0f for a full test report.

lexming
lexming requested changes Dec 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear if you want to have MPI support in this build of HighFive. The version of HDF5 loaded is MPI capable but the configuration option -DHIGHFIVE_PARALLEL_HDF5 is missing.

Instead, if you are not interested in MPI, we can keep the same configuration options and change the dependency on HDF5 to an easyconfig without MPI.

Let me know what you prefer and I can help you with the changes.

@lexming lexming added this to the 4.x milestone Dec 10, 2022
@guacke guacke requested a review from lexming December 18, 2022 15:30
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Dec 18, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 18, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16737 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16737 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9826

Test results coming soon (I hope)...

Details

- notification for comment with ID 1356904319 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 18, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/8ddd4cf72fd589da8dde4cf1103bdab5 for a full test report.

@lexming lexming changed the title {lib}[foss/2021a] HighFive v2.6.2 {lib}[gompi/2021a] HighFive v2.6.2 Dec 18, 2022
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Dec 18, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 18, 2022

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16737 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16737 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9827

Test results coming soon (I hope)...

Details

- notification for comment with ID 1356906021 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 18, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/15125f68c9457cfc47afc954144570ce for a full test report.

lexming
lexming approved these changes Dec 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guacke thanks for the update! I just made one extra change by moving HighFive down from the foss toolchain to gompi. Since HighFive does not depend on BLAS or Lapack it doesn't benefit from foss.

LGTM

@lexming lexming modified the milestones: 4.x, next release (4.7.0) Dec 18, 2022
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Dec 18, 2022

Going in, thanks @guacke !

@lexming lexming enabled auto-merge December 18, 2022 23:56
@lexming lexming merged commit a3e5e17 into easybuilders:develop Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@guacke @boegelbot @lexming